1020580 - Erase fails when a call to getDeviceStorage returns null

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[Guilherme Gonçalves [:ggp]]

Erase crashes when a call to getDeviceStorage() returns null for some of the storages [1]. Note that we should probably also guard against _all_ calls returning null, even though that sounds like an unlikely corner case.

Kate found the bug and is interested in working on it, so I'm assigning it to her for now. It should be an easy fix, and I'll be mentoring. I can fix it myself if she doesn't find the time to do it.

1- https://github.com/mozilla-b2g/gaia/blob/master/apps/findmydevice/js/commands.js#L149

Comment 1

[Kate Glazko]

Attachment: Proposed Fix for 'Erase' feature in FMD

Comment 2

[Guilherme Gonçalves [:ggp]]

Comment on attachment 8434513 [details] [review]
Proposed Fix for 'Erase' feature in FMD

Looks good!

Please rebase the patch on top of current gaia and push -f to re-run the tests, since your last run ended up red. It's probably not your fault and the rebase should give you a green run.

After that, please add 'checkin-needed' to the Keywords in the bug so a sheriff can land it for you. Then you'll be done :)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/403c08101cf78d685aa8ab86f02af6f4f9aac0f7

Comment 4

[Kate Glazko]

Apparently this was never uplifted?

Comment 5

[Guilherme Gonçalves [:ggp]]

Comment on attachment 8434513 [details] [review]
Proposed Fix for 'Erase' feature in FMD

This is a blocker that slipped by us, apologies.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1020580
[User impact] if declined: Erase feature will not work properly.
[Testing completed]: Travis and automated.
[Risk to taking this patch] (and alternatives if risky): None.
[String changes made]: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please don't reopen bugs for uplifts. Bug resolution tracks landing on trunk/master, not release branches. Status flags are for tracking uplifts.

Also, I'm not sure who tracks the "upliftneeded" whiteboard flag, but I'm guessing the people actually doing the uplifts (namely, myself) aren't. I rely on bug queries (which conveniently rely on things like bug resolution being properly set). Please don't reinvent new solutions to things without discussing them with relevant stakeholders first. If you have any questions or concerns about the process, I'm available on IRC pretty much all day during US working hours.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/aea264d9d0d5a2834e3cc681cda7b7e2d19bd366

Comment 8

[Jared Hirsch [:jhirsch] [:_6a68] (Needinfo please)]

Thanks, RyanVM!

Comment 9

[Erin Lancaster [:elan]]

Sorry about the whiteboard flag, Ryan! There were a few that were lost in the shuffle (not due to releng) I needed a sanity check on. I will follow up with QA on not re-opening.

Comment 10

[Lancy(Leave from Mozilla)]

Hi Guilherme,

Could you please provide the detailed reproduce steps or video for me to verify this bug?
Thank you very much!

Comment 11

[Guilherme Gonçalves [:ggp]]

I'm not sure this needs to be verified anymore. All of the relevant code was removed in bug 1040747.