Closed Bug 1020581 Opened 10 years ago Closed 10 years ago

Intermittent test_notification_resend.html | Notification timestamp is valid: 1401909554434

Categories

(Core :: DOM: Push Subscriptions, defect)

Product:
Core
Component:
DOM: Push Subscriptions
Version:
29 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
2.0 S3 (6june)
Tracking Flags:
Tracking Status
firefox30 --- unaffected
firefox31 --- unaffected
firefox32 --- fixed
firefox-esr24 --- unaffected
b2g-v1.4 --- unaffected
b2g-v2.0 --- fixed

People

(Reporter: RyanVM, Assigned: gerard-majax)

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe])

Attachments

(1 file)

0001-Bug-1020581-Notification-resend-test-feedback-improv.patch
1.20 KB, patch
mikehenrty
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=41050605&tree=Mozilla-Inbound

Windows XP 32-bit mozilla-inbound pgo test mochitest-4 on 2014-06-04 12:16:05 PDT for push 5c347ab86841
slave: t-xp32-ix-059

11:19:14     INFO -  176 INFO TEST-START | /tests/dom/tests/mochitest/notification/test_notification_resend.html
11:19:14     INFO -  177 INFO TEST-INFO | dumping last 35 message(s)
11:19:14     INFO -  178 INFO TEST-INFO | if you need more context, please use SimpleTest.requestCompleteLog() in your test
11:19:14     INFO -  179 INFO TEST-INFO | /tests/dom/tests/mochitest/notification/test_notification_resend.html | ::Notification Tests:: - Set manifestURL
11:19:14     INFO -  180 INFO TEST-INFO | /tests/dom/tests/mochitest/notification/test_notification_resend.html | ::Notification Tests:: - Value of manifestURL is: http://mochi.test:8888
11:19:14     INFO -  181 INFO TEST-INFO | /tests/dom/tests/mochitest/notification/test_notification_resend.html | ::Notification Tests:: - Test that we have mozChromeNotifications API
11:19:14     INFO -  182 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | should have mozChromeNotifications API
11:19:14     INFO -  183 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | should have mozResendAllNotifications()
11:19:14     INFO -  184 INFO TEST-INFO | /tests/dom/tests/mochitest/notification/test_notification_resend.html | ::Notification Tests:: - Making sure we have no previous notification pending
11:19:14     INFO -  185 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | notifications are all cleaned
11:19:14     INFO -  186 INFO TEST-INFO | /tests/dom/tests/mochitest/notification/test_notification_resend.html | ::Notification Tests:: - Sending one notification
11:19:14     INFO -  187 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification object is valid
11:19:14     INFO -  188 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | one notification has been sent
11:19:14     INFO -  189 INFO TEST-INFO | /tests/dom/tests/mochitest/notification/test_notification_resend.html | ::Notification Tests:: - Trying to resend the notification
11:19:14     INFO -  190 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | One notification resent
11:19:14     INFO -  191 INFO TEST-INFO | /tests/dom/tests/mochitest/notification/test_notification_resend.html | ::Notification Tests:: - Sending two notifications, closing one
11:19:14     INFO -  192 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification object is valid
11:19:14     INFO -  193 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification object is valid
11:19:14     INFO -  194 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | two notifications have been sent
11:19:14     INFO -  195 INFO TEST-INFO | /tests/dom/tests/mochitest/notification/test_notification_resend.html | ::Notification Tests:: - Checking if only notif2 is resent
11:19:14     INFO -  196 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | One notification resent
11:19:14     INFO -  197 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | one notification still available
11:19:14     INFO -  198 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | notification title is 'Title2'
11:19:14     INFO -  199 INFO TEST-INFO | /tests/dom/tests/mochitest/notification/test_notification_resend.html | ::Notification Tests:: - Checking ShowAppNotification behavior
11:19:14     INFO -  200 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | One notification resent
11:19:14     INFO -  201 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | AlertsServices has one app notification
11:19:14     INFO -  202 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | AlertsServices has one alert notification
11:19:14     INFO -  203 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification object is valid
11:19:14     INFO -  204 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification observer is valid
11:19:14     INFO -  205 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification title is valid: Title2
11:19:14     INFO -  206 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification body is valid: Body
11:19:14     INFO -  207 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification manifest URL is valid: http://mochi.test:8888
11:19:14     INFO -  208 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification icon URL is valid: icon.jpg
11:19:14     INFO -  209 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification lang is valid: en-US
11:19:14     INFO -  210 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification id is valid: http://mochi.test:8888#tag:fakeTag
11:19:14     INFO -  211 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification dbId is valid: {89d983b4-6022-49a8-874c-d02481bc79d4}
11:19:14     INFO -  212 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification dir is valid: ltr
11:19:14     INFO -  213 INFO TEST-PASS | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification tag is valid: fakeTag
11:19:14     INFO -  214 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/notification/test_notification_resend.html | Notification timestamp is valid: 1401909554434
11:19:14     INFO -  215 INFO TEST-INFO | MEMORY STAT vsize after test: 471146496
11:19:14     INFO -  216 INFO TEST-INFO | MEMORY STAT vsizeMaxContiguous after test: 813694976
11:19:14     INFO -  217 INFO TEST-INFO | MEMORY STAT residentFast after test: 297324544
11:19:14     INFO -  218 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 68210870
11:19:14     INFO -  219 INFO TEST-END | /tests/dom/tests/mochitest/notification/test_notification_resend.html | finished in 67ms
I suspect it may be because my test is too strict, i.e., (notif.timestamp > now).
Assignee: nobody → lissyx+mozillians
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S3 (6june)
Let be more cool with the timestamp checking and add more feedback to help with diagnostic of potential further failures.
Attachment #8434856 - Flags: review?(mhenretty)
Comment on attachment 8434856 [details] [diff] [review]
0001-Bug-1020581-Notification-resend-test-feedback-improv.patch

Review of attachment 8434856 [details] [diff] [review]:
-----------------------------------------------------------------

Easy one :)
Attachment #8434856 - Flags: review?(mhenretty) → review+
Keywords: checkin-needed
(In reply to TBPL Robot from comment #6)
>
> 214 INFO TEST-UNEXPECTED-FAIL |
> /tests/dom/tests/mochitest/notification/test_notification_resend.html |
> Notification timestamp is valid: (1403863205678 >= 1403863205679)
> Return code: 1

Alex, this makes absolutely no sense to me. It's like the timestamp on the notification is created back in time?? Any idea what is going on here?
Flags: needinfo?(lissyx+mozillians)
(In reply to Michael Henretty [:mhenretty] from comment #7)
> (In reply to TBPL Robot from comment #6)
> >
> > 214 INFO TEST-UNEXPECTED-FAIL |
> > /tests/dom/tests/mochitest/notification/test_notification_resend.html |
> > Notification timestamp is valid: (1403863205678 >= 1403863205679)
> > Return code: 1
> 
> Alex, this makes absolutely no sense to me. It's like the timestamp on the
> notification is created back in time?? Any idea what is going on here?

Maybe wwe are getting this difference because of the ordering of calls. I have no idea of the underlying behavior, but we have async stuff everywhere :(
Flags: needinfo?(lissyx+mozillians)
(In reply to Alexandre LISSY :gerard-majax from comment #8)
> (In reply to Michael Henretty [:mhenretty] from comment #7)
> > (In reply to TBPL Robot from comment #6)
> > >
> > > 214 INFO TEST-UNEXPECTED-FAIL |
> > > /tests/dom/tests/mochitest/notification/test_notification_resend.html |
> > > Notification timestamp is valid: (1403863205678 >= 1403863205679)
> > > Return code: 1
> > 
> > Alex, this makes absolutely no sense to me. It's like the timestamp on the
> > notification is created back in time?? Any idea what is going on here?
> 
> Maybe wwe are getting this difference because of the ordering of calls. I
> have no idea of the underlying behavior, but we have async stuff everywhere
> :(

> now = new Date().getTime()
> notif.timestamp = ???

Could one be defined based on the cpu counter, and rounded down/up?
Are both timestamps acquired the same way?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: