Closed Bug 1020605 Opened 6 years ago Closed 6 years ago

gaia-grid does not append icons to shadow root

Categories

(Firefox OS Graveyard :: Gaia, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S4 (20june)
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

This breaks accessibility.
Comment on attachment 8434462 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20033

Amazing how we could completely break accessibility =) Thanks for the patch, left a comment on github to see if we could get rid of the content tag.
Attachment #8434462 - Flags: review?(kgrandon) → review+
Thanks! Like I mentioned in the PR, we need the <content> tag to insert the children.

https://github.com/mozilla-b2g/gaia/commit/763b7f62805570b1606b8738075318020af3fa7d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1007857
It would be good to test this on try.. I've noticed that we have an intermittent framework issue, I wonder if it could cause this test to appear to timeout?

INFO -  Xlib:  extension "RANDR" missing on display ":0".
(In reply to Kevin Grandon :kgrandon from comment #5)
> It would be good to test this on try.. I've noticed that we have an
> intermittent framework issue, I wonder if it could cause this test to appear
> to timeout?
> 
> INFO -  Xlib:  extension "RANDR" missing on display ":0".

I don't think that should be an issue.
Running this on try again, just to isolate it:
https://tbpl.mozilla.org/?tree=Try&rev=8dbdb58a9a48
Here is a successful run. But I suspect it didn't pull in my remote/branch..

https://tbpl.mozilla.org/?tree=Try&rev=752a12221d72
Here is a rebased version. There seems to be general instability in our CI, but I am fairly certain that this pull request does not make tests fail.

Can I land this?
Attachment #8434462 - Attachment is obsolete: true
Flags: needinfo?(kgrandon)
Sure, let's land it. Thanks!

https://github.com/mozilla-b2g/gaia/commit/eef5b7a6f2722aa223422759b04b0e78a138ac97
Assignee: nobody → eitan
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Flags: needinfo?(kgrandon)
Resolution: --- → FIXED
Comment on attachment 8438785 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20159

This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.
Attachment #8438785 - Flags: approval-gaia-v2.0?(bbajaj)
Attachment #8438785 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
You need to log in before you can comment on or make changes to this bug.