gaia-grid does not append icons to shadow root

RESOLVED FIXED in Firefox OS v2.0

Status

Firefox OS
Gaia
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

(Blocks: 2 bugs, {access})

unspecified
2.0 S4 (20june)
All
Gonk (Firefox OS)
access
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.0 fixed, b2g-v2.1 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
This breaks accessibility.
(Assignee)

Comment 1

4 years ago
Created attachment 8434462 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20033
Attachment #8434462 - Flags: review?(kgrandon)
Comment on attachment 8434462 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20033

Amazing how we could completely break accessibility =) Thanks for the patch, left a comment on github to see if we could get rid of the content tag.
Attachment #8434462 - Flags: review?(kgrandon) → review+
(Assignee)

Comment 3

4 years ago
Thanks! Like I mentioned in the PR, we need the <content> tag to insert the children.

https://github.com/mozilla-b2g/gaia/commit/763b7f62805570b1606b8738075318020af3fa7d
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Blocks: 1007857
Revert for Gaia unit test timeouts.
Master: https://github.com/mozilla-b2g/gaia/commit/d04b7196fb59834704ef38d400c813b7ea68d755

https://tbpl.mozilla.org/php/getParsedLog.php?id=41134833&tree=B2g-Inbound
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
It would be good to test this on try.. I've noticed that we have an intermittent framework issue, I wonder if it could cause this test to appear to timeout?

INFO -  Xlib:  extension "RANDR" missing on display ":0".
(Assignee)

Comment 6

4 years ago
(In reply to Kevin Grandon :kgrandon from comment #5)
> It would be good to test this on try.. I've noticed that we have an
> intermittent framework issue, I wonder if it could cause this test to appear
> to timeout?
> 
> INFO -  Xlib:  extension "RANDR" missing on display ":0".

I don't think that should be an issue.
Running this on try again, just to isolate it:
https://tbpl.mozilla.org/?tree=Try&rev=8dbdb58a9a48
(Assignee)

Comment 7

4 years ago
Here is a successful run. But I suspect it didn't pull in my remote/branch..

https://tbpl.mozilla.org/?tree=Try&rev=752a12221d72
(Assignee)

Comment 8

4 years ago
Created attachment 8438785 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20159

Here is a rebased version. There seems to be general instability in our CI, but I am fairly certain that this pull request does not make tests fail.

Can I land this?
Attachment #8434462 - Attachment is obsolete: true
Flags: needinfo?(kgrandon)
Sure, let's land it. Thanks!

https://github.com/mozilla-b2g/gaia/commit/eef5b7a6f2722aa223422759b04b0e78a138ac97
Assignee: nobody → eitan
Blocks: 989848
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Flags: needinfo?(kgrandon)
Resolution: --- → FIXED
Comment on attachment 8438785 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20159

This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.
Attachment #8438785 - Flags: approval-gaia-v2.0?(bbajaj)

Updated

4 years ago
status-b2g-v2.0: --- → affected
status-b2g-v2.1: --- → fixed

Updated

4 years ago
Attachment #8438785 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
v2.0: https://github.com/mozilla-b2g/gaia/commit/cdd75128f7510b4dc04142a8a4bab38acd890967
status-b2g-v2.0: affected → fixed
Target Milestone: --- → 2.0 S4 (20june)
You need to log in before you can comment on or make changes to this bug.