Closed Bug 1020651 Opened 10 years ago Closed 10 years ago

about:preferences do not work properly if browser.cache.disk.enable is false

Categories

(Firefox :: Settings UI, defect)

32 Branch
x86
Linux
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 33

People

(Reporter: striptm, Assigned: evilpie)

References

Details

Attachments

(1 file)

Steps to reproduce:

Firefox nightly 32.0a1 (2014-06-04)
Open about:preferences with an old profile.

Actual results:
some part of about:preferences do not work properly.

In console:

NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsICacheService.visitEntries] advanced.js:314
ReferenceError: reference to undefined property this._path osfile_win_front.jsm:837


Setting browser.cache.disk.enable=true solve the bug

Note: See https://bugzilla.mozilla.org/show_bug.cgi?id=795764#c21
Depends on: 795764
Assignee: nobody → evilpies
Status: NEW → ASSIGNED
I am not surprised that this throws an error, but somehow I can't reproduce it by setting browser.cache.disk.enabled to false.
I can reproduce: You have to set browser.cache.disk.enable AND browser.cache.memory.enable to false.
Attached patch v1Splinter Review
I could reproduce this now, thanks! I just wrapped every cache related call into try .. catch, also fixes the issue.
Attachment #8437830 - Flags: review?(jaws)
Comment on attachment 8437830 [details] [diff] [review]
v1

Review of attachment 8437830 [details] [diff] [review]:
-----------------------------------------------------------------

Can you update browser_bug795764_cachedisabled.js to include this case?
Attachment #8437830 - Flags: review?(jaws) → review+
What does the UI look like in these cases (this bug and bug 795764)? Just catching the exception makes things initialize properly, but I wonder if the UI needs to be adjusted to not look weird.
https://hg.mozilla.org/mozilla-central/rev/5fd74801fa00
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Verified in Nightly 33.0a1 (2014-06-15)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: