1020656 - Quick scroll and search are still visible to screen reader when no contacts dialog is shown

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Eitan Isaacson [:eeejay]]

The no contacts dialog depends on z-index to hide the quickscroll and contacts scrollable pane.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20038

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8434539 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20038

Hi Eitan,

can we modify unit test to check for the class hide when it should be.

Right now I think we can modify:
https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/test/unit/views/list_test.js#L949

and check that when we go from 1 contact to 0, we add the hide class to the correct element.

Thanks a lot!

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8434539 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20038

Sorry Eitan, forgot to remove the flag, could you add the unit test that was commenting previously?

Comment 4

[Eitan Isaacson [:eeejay]]

Comment on attachment 8434539 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20038

Added unit tests!

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8434539 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20038

Hi Eitan!

We had some errors in travis:
https://travis-ci.org/mozilla-b2g/gaia/jobs/27149203

I'm relaunching them to see if they are intermitent or permanent cause of this patch.

Comment 6

[Eitan Isaacson [:eeejay]]

Re-aligning priorities with 2.1 accessibility goals.

Comment 7

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/02f667167ff7adce58a3666e241621dfa7b95c2e