Closed Bug 1020685 Opened 6 years ago Closed 3 years ago

Fix leak via contextmenu handler

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: khuey, Assigned: khuey)

References

Details

(Whiteboard: [MemShrink:P2])

Attachments

(1 file)

We're closing over an object, not just the URI we want, so we're entraining a bunch more than we need to (in particular potentially data URIs for the icon).
Attached file Link to PR
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #8434580 - Flags: review?(bfrancis)
Whiteboard: [MemShrink]
Comment on attachment 8434580 [details] [review]
Link to PR

Thanks Kyle.

r+, OK to land once Travis is green.
Attachment #8434580 - Flags: review?(bfrancis) → review+
The failure looks unrelated.
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/d16fa6a679da9bd0d5f48366063c7e8c2a12b4b6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S3 (6june)
Reverted in https://github.com/mozilla-b2g/gaia/commit/28e9b207fa9a6f42ad94459ddb3057f7e240f796 due to bug 1022848
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 1022848
So I guess the URL can change over time, and we need to bind to the object instead of the string?
Flags: needinfo?(bfrancis)
Revert landed on v2.0 branch as well.
Target Milestone: 2.0 S3 (6june) → ---
Whiteboard: [MemShrink] → [MemShrink:P2]
Clearing NEEDINFO as this is probably going to be WONTFIX
Flags: needinfo?(bfrancis)
Status: REOPENED → RESOLVED
Closed: 6 years ago3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.