Closed Bug 1020685 Opened 6 years ago Closed 3 years ago
Fix leak via contextmenu handler
We're closing over an object, not just the URI we want, so we're entraining a bunch more than we need to (in particular potentially data URIs for the icon).
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #8434580 - Flags: review?(bfrancis)
6 years ago
Comment on attachment 8434580 [details] [review] Link to PR Thanks Kyle. r+, OK to land once Travis is green.
Attachment #8434580 - Flags: review?(bfrancis) → review+
The failure looks unrelated.
Reverted in https://github.com/mozilla-b2g/gaia/commit/28e9b207fa9a6f42ad94459ddb3057f7e240f796 due to bug 1022848
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
So I guess the URL can change over time, and we need to bind to the object instead of the string?
Revert landed on v2.0 branch as well.
Clearing NEEDINFO as this is probably going to be WONTFIX
3 years ago
Status: REOPENED → RESOLVED
Closed: 6 years ago → 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.