[Video]Video Pick activity Header is not aligned with Gallery Header

UNCONFIRMED
Unassigned

Status

Firefox OS
Gaia::Video
UNCONFIRMED
4 years ago
3 years ago

People

(Reporter: vsireesha246, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: interaction-design[g+])

Attachments

(6 attachments)

(Reporter)

Description

4 years ago
The Video Pick activity Header is different from Gallery Pick activity Header.

STR:
1.Open SMS/Email
2.Select attachment as Video->Check the Header Back button,space between back and "Select a Video" is more and background header color
3.Select attachment as Gallery and check the Header

Gallery and Video Pick activity Header should be same.
(Reporter)

Comment 1

4 years ago
Created attachment 8434778 [details]
Bug_1020836.png
(Reporter)

Updated

4 years ago
Flags: needinfo?(tshakespeare)
(Reporter)

Comment 2

4 years ago
This issue is present in Version 1.4.
That is very odd indeed. For 1.4 they should both be left-aligned and match up. For 2.0, they should both be centered due to visual design changes to the Header BB.

Do we know if these pickers are using the Header BB?
Flags: needinfo?(tshakespeare)
Russn - can you take a look when you have a moment? Thanks! :)
Flags: needinfo?(rnicoletti)
Whiteboard: interaction-design
(Reporter)

Updated

4 years ago
Whiteboard: interaction-design → interaction-design[g+]
I'm not familiar with the changes to the header BB. Tif, can you elaborate on those? Both elements in 1.4 and master are using the "icon-back" class. I don't see differences in the css between 1.4 and master. I'm guessing I'm not looking in the right place.
Flags: needinfo?(rnicoletti)
Flags: needinfo?(tshakespeare)
Created attachment 8436221 [details]
Video and Gallery screenshot

It's mainly around the text - it's now centered and the font is different.

I actually just tried to repro today and the headers are different than the original attachment though the alignment still looks funky.

See attached.

Build info is Flame
Gaia      857129928b6e56a809cee9d5445effb8fa9f1c2c
Gecko     https://hg.mozilla.org/mozilla-central/rev/c8288d0c7a15
BuildID   20140606040202
Version   32.0a1
Flags: needinfo?(tshakespeare)
Created attachment 8446776 [details]
gallery pick header (with text from video)
Created attachment 8446777 [details]
video_pick.png
To test the alignment and font, I updated gallery to use the same 'select' text as the video app: 'Select a Video'. As you can see from the attachments in comment #7 and comment #8, the font and the alignment is identical between the gallery and video pick headers. As you can also see, the background of the headers is different. This I will continue to investigate.
Which of the background colors is correct, the grey or the black? I'm assuming grey but I'd like to confirm. Thanks.
Flags: needinfo?(tshakespeare)
I'm attaching two more images, one of the CSS hierarchy of the gallery pick header and one of the CSS hierarchy of the video pick header. It seems the backgrounds are different because in the case of the video header both headers.css 'background-color' properties are crossed out, while in the case of gallery only one is crossed out. My knowledge/understanding of CSS is limited. How does a CSS property become crossed out in app manager?
Created attachment 8446830 [details]
app manager view of gallery pick header
Created attachment 8446832 [details]
app manager view of video pick header
Hello! Sorry for the delay. I spoke with Amy and we should be using grey like what is in Gallery edit mode. Thanks for double checking Russ!
Flags: needinfo?(tshakespeare)
You need to log in before you can comment on or make changes to this bug.