1020848 - When phone hasn't coverage and balance is below a determinate amount, texts aren't correctly aligned

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Loli (:lolimartinezcr)]

Attachment: 2014-06-05-03-46-01.png

Tested
Open C
Build ID: 20140603121811
Platform versión: 32.0a1
Git commmit:26d8fcab

Reproducible: 100%

Pre-requisites:
1. Configured: Balance is bellow and alert with balance.
2. Not coverage in device.
3. Prepaid SIM card and with billing support.

STRs:
Tap cost control application.

Actual result:
See attached image.

Expected result:
Texts are correctly aligned.

Comment 1

[Jason Smith [:jsmith]]

Does this happen on 1.4?

Comment 2

[Loli (:lolimartinezcr)]

(In reply to Jason Smith [:jsmith] from comment #1)
> Does this happen on 1.4?

The problem is I’m not sure we have a 1.4 build for OpenC/Flame

Comment 3

[Jason Smith [:jsmith]]

(In reply to Loli from comment #2)
> (In reply to Jason Smith [:jsmith] from comment #1)
> > Does this happen on 1.4?
> 
> The problem is I’m not sure we have a 1.4 build for OpenC/Flame

Clarified offline - reproduces on 1.4. Let's also check 1.3 as well.

Comment 4

[Loli (:lolimartinezcr)]

(In reply to Jason Smith [:jsmith] from comment #3)
> (In reply to Loli from comment #2)
> > (In reply to Jason Smith [:jsmith] from comment #1)
> > > Does this happen on 1.4?
> > 
> > The problem is I’m not sure we have a 1.4 build for OpenC/Flame
> 
> Clarified offline - reproduces on 1.4. Let's also check 1.3 as well.

The problem is I’m not sure we have a 1.3 build for OpenC/Flame

Comment 5

[Jason Smith [:jsmith]]

(In reply to Loli from comment #4)
> (In reply to Jason Smith [:jsmith] from comment #3)
> > (In reply to Loli from comment #2)
> > > (In reply to Jason Smith [:jsmith] from comment #1)
> > > > Does this happen on 1.4?
> > > 
> > > The problem is I’m not sure we have a 1.4 build for OpenC/Flame
> > 
> > Clarified offline - reproduces on 1.4. Let's also check 1.3 as well.
> 
> The problem is I’m not sure we have a 1.3 build for OpenC/Flame

Can we check 1.3 Buri instead then?

Comment 6

[Loli (:lolimartinezcr)]

(In reply to Jason Smith [:jsmith] from comment #5)
> (In reply to Loli from comment #4)
> > (In reply to Jason Smith [:jsmith] from comment #3)
> > > (In reply to Loli from comment #2)
> > > > (In reply to Jason Smith [:jsmith] from comment #1)
> > > > > Does this happen on 1.4?
> > > > 
> > > > The problem is I’m not sure we have a 1.4 build for OpenC/Flame
> > > 
> > > Clarified offline - reproduces on 1.4. Let's also check 1.3 as well.
> > 
> > The problem is I’m not sure we have a 1.3 build for OpenC/Flame
> 
> Can we check 1.3 Buri instead then?

It is reproducible in 1.3

Comment 7

[Marina Rodríguez [:mai]]

Hi Eric, 
would you give us your feedback about this issue?
Regards

Comment 8

[Eric Pang [:epang] UX]

(In reply to marina rodríguez [:mai] from comment #7)
> Hi Eric, 
> would you give us your feedback about this issue?
> Regards

Hi Marina, I'm going to hand this off to Vicky since I believe she owns cost control at the moment.  Vicky let me know if I'm mistaken :)

Comment 9

[Maria Angeles Oteo (:oteo)]

Hi Eric,
Rafa is in charge of Cost Control issues, changing the ni according to it

Comment 10

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi Salva, 
would you mind review the patch?
Regards

Comment 11

[Marina Rodríguez [:mai]]

Attachment: patch-alig-text.png

Attached a image to show the behaviour of the patch

Comment 12

[Salvador de la Puente González [:salva]]

Comment on attachment 8469877 [details] [review]
patch v1.0

Nice. Thank you.

Comment 13

[Marina Rodríguez [:mai]]

Master: 0b7676424360f43205cc21440c7eb57e07f906e6

Comment 14

[Loli (:lolimartinezcr)]

Tested and working
Flame
Gecko-d5a4ba9
Gaia-80a41e0