Closed Bug 102085 Opened 23 years ago Closed 23 years ago

default nsFontPackageHandler should be in xpfe

Categories

(Core :: Internationalization, defect, P2)

x86
Windows 2000
defect

Tracking

()

RESOLVED FIXED
mozilla0.9.5

People

(Reporter: alecf, Assigned: alecf)

References

Details

(Keywords: intl, Whiteboard: fix in hand)

Attachments

(2 files, 1 obsolete file)

the current nsFontPackageHandler opens a window which directs people to
mozilla.org. embedded applications should have their own font handlers.

It looks like someone started work on this, but it needs to be abstracted out,
and the actual nsFontPackageHandler implementation should reside in
xpfe/components so that i18n libraries do not have unnecessary dependencies on
windowwatcher/etc.

patches forthcoming.
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.5
also see bug 100204, where I'm doing something similar with the charset menu
Blocks: 100107
oops, make that bug 102004
The second patch also adds the stuff from bug 102004. The files removed have
been moved to:

http://lxr.mozilla.org/seamonkey/source/xpfe/components/intl/
Comment on attachment 51326 [details] [diff] [review]
removal of nsFontPackageHandler, use do_CreateInstance

r=ftang
Attachment #51326 - Flags: review+
Comment on attachment 51330 [details] [diff] [review]
add the new static library to the build

r=ftang
Attachment #51330 - Flags: review+
Keywords: intl
QA Contact: andreasb → ylong
Comment on attachment 51330 [details] [diff] [review]
add the new static library to the build

sr=shaver
Attachment #51330 - Flags: superreview+
Attachment #51330 - Attachment is obsolete: true
Attachment #51590 - Flags: superreview+
Attachment #51590 - Flags: review+
Comment on attachment 51326 [details] [diff] [review]
removal of nsFontPackageHandler, use do_CreateInstance

Thou Shalt Not Put Contract IDs Or Other Implementation Identifiers In IDL Files.

Put that sucker in a Utils.h or something (better: don't put it anywhere, as per your thread in .xpcom), and sr=shaver.
Attachment #51326 - Flags: superreview+
hope to land this today if the tree ever opens :)
Whiteboard: fix in hand
everything has landed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Frank, could you or some other one can verify this?  Thanks!
QA Contact: ylong → ftang
We need to remove nsFontPackageHandler.cpp and nsFontPackageHandler.h
from \intl\locale\src.

alecf: Please remove them.  Thanks
Status: RESOLVED → REOPENED
QA Contact: ftang → yokoyama
Resolution: FIXED → ---
Target Milestone: mozilla0.9.5 → mozilla0.9.8
I'll remove them, but let's leave the bug how it is, and not make it look like I
fixed anything in 0.9.8. The bug is "nsFontPackageHandler should be in xpfe",
which it is.
Status: REOPENED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
Target Milestone: mozilla0.9.8 → mozilla0.9.5
ok. thanks
oh, and I removed the files this morning, after making the comment :)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: