1020866 - [Wifi] Flame doesn't send MSCHAPv2 request when configuring phase 2 authentication as "MSCHAP V2"

Status: VERIFIED FIXED

Description

[Gerry Chang [:gchang] - On PTO - Back on October 20]

Created attachment 8434822 [details]
The logs of flame

### Steps:
1. Navigate to Settings > Wi-Fi page
2. Choose the network supporting WPA-EAP TTLS
3. Select "TTLS" in EAP method
4. Select "MSCHAP V2" in phase 2 authentication
5. Type username and password
6. Tap "OK" button

### Expected:
1. The wireless network should be connected.
2. From radius server, the MSCHAP request should be sent.

### Actual:
1. Device doesn't send MSCHAP request.
2. Device can connecto to network

### Reproduce rate
always

### Version:
Device    flame
Gaia      a38a6a5c6fabc97dd16d5360632b5ac5c7e06241
Gecko     https://hg.mozilla.org/mozilla-central/rev/951e3a671279
BuildID   20140604160202
Version   32.0a1

Comment 1

[Gerry Chang [:gchang] - On PTO - Back on October 20]

Created attachment 8434825 [details]
The logs of radius server

Comment 2

[Gerry Chang [:gchang] - On PTO - Back on October 20]

From the logs in radius server, there should be "MS-CHAP-Challenge" & "MS-CHAP2-Response" shown in server. Below is an example.
[ttls] Got tunneled request
	User-Name = "sqa"
	MS-CHAP-Challenge = 0x66c9d6f7408432c625f638ce33b0b5ca
	MS-CHAP2-Response = 0xc1008d568db0bdf98b8002ffe9ebf90729720000000000000000d244c2b574dfbf9b27a99dbf6b5b928acf0abb9a56f72265
	FreeRADIUS-Proxied-To = 127.0.0.1

Comment 3

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

It seems that we need to add "IEEE8021X" to key_mgmt while using WPA-EAP to use phase 2 authentication.

Comment 4

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Created attachment 8437534 [details] [diff] [review]
0001. Add IEEE8021X to WPA-EAP config.

Comment 5

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8437534 [details] [diff] [review]
0001. Add IEEE8021X to WPA-EAP config.

Review of attachment 8437534 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thank you.

Comment 6

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Created attachment 8439680 [details] [diff] [review]
Add IEEE8021X to WPA-EAP config. V2. r=vchang

Prevent IEEE8021X being sent out in network information, this will be shown in Setting UI and cause confusion.

Comment 7

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try looks good: https://tbpl.mozilla.org/?tree=Try&rev=35f714434540

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d689f1b53926

Comment 9

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/d689f1b53926

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/434177365679

Comment 11

[Gerry Chang [:gchang] - On PTO - Back on October 20]

Verified @
Gaia      43226cf5c3ad19728a88b3786595670b6d60e5c6
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/d0275ba5f438
BuildID   20140701160202
Version   32.0a2