1020874 - Add optional parameters x and y to Action.long_press()

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

We should allow long_press() to accept coordinate x, y as press() does.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Add option parameters x and y to Action.long_press()

Try result (opt):
https://tbpl.mozilla.org/?tree=Try&rev=64481649449f

Try result (debug):
https://tbpl.mozilla.org/?tree=Try&rev=0fe64f66bcb6

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8434840 [details] [diff] [review]
Add option parameters x and y to Action.long_press()

Review of attachment 8434840 [details] [diff] [review]:
-----------------------------------------------------------------

Cool! Will you please add a small test for this in testing/marionette/client/marionette/tests/unit/test_single_finger.py and testing/marionette/client/marionette/tests/unit/test_single_finger_desktop.py, please? Thanks!

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

(In reply to Malini Das [:mdas] from comment #2)
> Cool! Will you please add a small test for this in
> testing/marionette/client/marionette/tests/unit/test_single_finger.py and
> testing/marionette/client/marionette/tests/unit/test_single_finger_desktop.
> py, please? Thanks!

The tests in test_single_finger.py and test_single_finger_desktop.py are all clicking on some buttons. 
Is it sufficient to test long_press() on a button at (x, y), say (1, 1), and see if the button is long pressed?

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

(In reply to Ting-Yu Lin [:TYLin] from comment #3)
> The tests in test_single_finger.py and test_single_finger_desktop.py are all
> clicking on some buttons. 
> Is it sufficient to test long_press() on a button at (x, y), say (1, 1), and
> see if the button is long pressed?

Not quite, we have no guarantee that (1,1) is being taken into account, since the default behaviour (touching the center of the element) and tapping at (1,1) is indistinguishable, so if we break coordinate-based longPress, we wouldn't know it.

A good test for this is to tap an element which is at a particular point, and is not near the center of the element you are tapping. To do this, I would add a button on the test page which is at (0, 30) for example, and add a 'touchstart' and 'contextmenu' listener on it. To dispatch the long press, you would use the 'body' element as the target, with (0,30) as the offset. Since 'body' is the parent of this new element, the touch event will propagate to the button, so your listeners should be fired.

These tests use testAction.html (https://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/www/testAction.html?raw=1) as their test page, so what you can do is something like:

body = marionette.find_element("tag name", "body")
button = marionette.find_element("id", "myNewButton")
actions.long_press(body, 5, button.location['x'], button.location['y'])

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Hi Malini, 

Thanks for the clear explanation. I'll see what I can do.

Comment 6

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8434840 [details] [diff] [review]
Add option parameters x and y to Action.long_press()

Review of attachment 8434840 [details] [diff] [review]:
-----------------------------------------------------------------

clearing flag

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Add optional parameters x and y to Action.long_press() (v2)

Add test cases in test_single_finger.py and test_single_finger_desktop.py.

Try (Mnw, Gu): https://tbpl.mozilla.org/?tree=Try&rev=77a0f5cdb2d4
Try (Mn): https://tbpl.mozilla.org/?tree=Try&rev=8397ecb4e3dc

Comment 8

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8436413 [details] [diff] [review]
Add optional parameters x and y to Action.long_press() (v2)

Review of attachment 8436413 [details] [diff] [review]:
-----------------------------------------------------------------

this looks perfect, thanks for doing this!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/ca3b94cfe665

Comment 10

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

It's good to see this reviewed and merged in the morning.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ca3b94cfe665