Use python from environment in create_venv.py when installing TPS

RESOLVED FIXED in Firefox 31

Status

Testing
TPS
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: cosmin, Assigned: cosmin)

Tracking

31 Branch
mozilla32
All
Windows 7
Points:
---

Firefox Tracking Flags

(firefox30 wontfix, firefox31 fixed, firefox32 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
This is a followup for bug 1009004, where the python script does that creates the environment has to use the python executable from the environment in order install it in environment, otherwise it will install it globally, regardless that we activate the new created venv.
(Assignee)

Comment 1

4 years ago
Created attachment 8434843 [details] [diff] [review]
patch_v1.0

With this patch applied on a tests directory I ran them via coversheet from Windows Powershell:
> C:\Python27\Scripts\coversheet.exe --pulsefile .\tests\pulse_messages\mozilla-central.en-US.win32.json --configfile .\config\config.json
And it ran the testrun.
Attachment #8434843 - Flags: review?(hskupin)
Comment on attachment 8434843 [details] [diff] [review]
patch_v1.0

Review of attachment 8434843 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense. Thanks for the patch.
Attachment #8434843 - Flags: review?(hskupin) → review+
https://hg.mozilla.org/mozilla-central/rev/7297cfffd91c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox30: --- → wontfix
status-firefox31: --- → affected
status-firefox32: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Cosmin, please watch landings of your patches and on which branches it needs to be backported. I haven't hard anything from you regarding this backport.

https://hg.mozilla.org/releases/mozilla-beta/rev/243aeb5a83a0

Also make sure you file a bug for the credential place-holders in the default config file. We have to get this landed ASAP.
status-firefox31: affected → fixed
(Assignee)

Comment 5

4 years ago
Created attachment 8444330 [details] [diff] [review]
patch_v1.0 [release]

This fix has been merged down to beta branch, this patch is for Release.
It contains the commit form bug 1009004 and this follow-up fix.
For placeholders I filed bug 1028030.
Attachment #8444330 - Flags: review?(hskupin)
Comment on attachment 8444330 [details] [diff] [review]
patch_v1.0 [release]

Please read the version flags. This bug is wontfix for Firefox 30.0. This release went out a while ago, and no-one cares about this release branch.
Attachment #8444330 - Attachment is obsolete: true
Attachment #8444330 - Flags: review?(hskupin)
You need to log in before you can comment on or make changes to this bug.