1020890 - [Calendar] "Notes " does not change in respective language in view event.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Vishnu Dangi]

STR:
1.change language other then english
2.Calendar> New Event> Notes> Text Input> Save Event
3.Click on previously Saved event.
4."Notes" always in English language.
5.Gaia-master
Expected Result :"Notes" should be change in respective language.

Comment 1

[Vishnu Dangi]

Attachment: our approach to solve this issue: Use h2 element with datl10n id for "Notes" instead of strong element in file gaia\apps\calendar\elements\show_event.html added a new string in en US and other langu

Comment 2

[Vishnu Dangi]

Attached patch has the changes for it
Please give your feedback.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8434888 [details] [diff] [review]
our approach to solve this issue:  Use h2 element with datl10n id for "Notes" instead of strong element in file gaia\apps\calendar\elements\show_event.html  added a new string in en US and other langu

Review of attachment 8434888 [details] [diff] [review]:
-----------------------------------------------------------------

Looks simple enough to me - does the styling remain ok? Can you open up a pull request against gaia master? Thanks!

Comment 4

[Vishnu Dangi]

Attachment: Pointer to Pull Request.html

Please review this.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8435539 [details]
Pointer to Pull Request.html

Thanks!

Comment 6

[BMO Automation]

Firefox OS is not being worked on