1020958 - [Collection App] Loading more results

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Amir Nissim (:amirn)]

When viewing a Collection, scrolling down should trigger loading of more results.

Comment 1

[Amir Nissim (:amirn)]

is this a blocker for 2.0?

Comment 2

[Peter Dolanjski [:pdol]]

(In reply to Amir Nissim (Everything.me) from comment #1)
> is this a blocker for 2.0?

As opposed to having a fix number of results?
If so, how many would be in the fixed set?

NI on Francis as he'll likely have input.

Comment 3

[Ran Ben Aharon [:ranbena] EverythingMe]

I'd rather not bypass this feature. Let's discuss this if it's at risk of not making it.

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Kevin, this feature requires a "reached bottom of results" event when scroll ends. In 1.x we did that with a custom script of ours "scroll.js" which implements polling and listens to scroll and touch events. Works well but not very elegant.

Any suggestion on how to implement this differently? Perhaps some actual "scrollend" event? Or maybe an "element visible in viewport" event?

Comment 5

[Kevin Grandon :kgrandon]

We have the next two weeks to focus on smart collections, so I'd say there should be no problem including this.

Regarding implementation, for now I do think it should live in the collection app, until we need it elsewhere in the system. I'm fine if we want to port scroll.js over, or use a new library. The only hooks it should need from the gaia grid is grid.add() and grid.render().

I'm not sure of the exact reasoning behind the touch listeners in scroll.js - if we could do it with only a scroll listener it might be better.

Comment 6

[Francis Djabri [:djabber]]

(In reply to Ran Ben Aharon (Everything.me) from comment #3)
> I'd rather not bypass this feature. Let's discuss this if it's at risk of
> not making it.

I agree. This doesn't seem like a blocker but we should include it if possible.

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: WIP

Comment 8

[Amir Nissim (:amirn)]

Attachment: WIP: loading 48 results, rendering in batches

due to time constraints, attaching another approach that gets 48 results from the API and then renders them in batches.

Comment 9

[Kevin Grandon :kgrandon]

This is not a blocker, but we could consider taking it and uplifting, so moving to block vhomescreen.next.

I'm also cautious about the performance of so many results - we have a lot of work to do on the perfomance, so we should address that first. See bug 1028452.

Comment 10

[Kevin Grandon :kgrandon]

Mass update: Resolve/Wontfix all existing collections bugs as this feature is now removed.

Please re-open or file a new bug if you feel that this bug still exists in master.