Closed
Bug 102096
Opened 25 years ago
Closed 25 years ago
nsICharsetAlias uses nsString in and out params for GetPreferred() and Equals()
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(3 files, 2 obsolete files)
|
9.54 KB,
patch
|
ftang
:
review+
|
Details | Diff | Splinter Review |
|
9.69 KB,
patch
|
Details | Diff | Splinter Review | |
|
9.29 KB,
patch
|
jag+mozilla
:
review+
|
Details | Diff | Splinter Review |
nsICharsetAlias uses nsString in and out params for GetPreferred(). This means
that calling if from a well-behaved method that's using nsAStrings involves two
string copies. This is bad.
|
Assignee | |
Comment 2•25 years ago
|
||
|
|
Assignee | |
Comment 3•25 years ago
|
||
|
|
Assignee | |
Updated•25 years ago
|
Attachment #51218 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•25 years ago
|
||
Reviews?
ccing scc because there's string stuff and xpcom stuff here.
|
|
||
Comment 5•25 years ago
|
||
Comment on attachment 51219 [details] [diff] [review]
Forgot to change something that's in an #if 0....
r=ftang
Attachment #51219 -
Flags: review+
|
||
Comment 6•25 years ago
|
||
Comment on attachment 51219 [details] [diff] [review]
Forgot to change something that's in an #if 0....
Can we lose the .EqualsWithConversion("utf-8") in GetPreferred, and use an
NS_LITERAL_STRING jobbie?
|
|
Assignee | |
Comment 7•25 years ago
|
||
|
|
Assignee | |
Comment 8•25 years ago
|
||
shaver says sr=shaver on irc
|
|
||
Comment 9•25 years ago
|
||
bzbarsky: should I assign this bug to you?
|
|
Assignee | |
Comment 11•25 years ago
|
||
|
|
Assignee | |
Updated•25 years ago
|
Attachment #51314 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 12•25 years ago
|
||
|
|
Assignee | |
Comment 13•25 years ago
|
||
jag, could you take a look at this and review too? You said that it looked ok,
but it sounded like you wanted to take some more time with it....
|
||
Comment 14•25 years ago
|
||
Comment on attachment 51411 [details] [diff] [review]
Patch taking into account jag's landing from yesterday
r=jag
Attachment #51411 -
Flags: review+
|
|
Assignee | |
Comment 15•25 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
|
|
||
Comment 16•25 years ago
|
||
Switching QA contact to ftang for now. Frank, can this bug be verified within
development or can you provide IQA with a test case? Thanks.
QA Contact: andreasb → ftang
You need to log in
before you can comment on or make changes to this bug.
Description
•