1020961 - [Collection app] Loading progress indicator and Connectivity message

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

Progress indicator should appear when Collection app is initializing and when external search results are fetched.

A "no connection" message should appear in the search results area when device not connected to internet.

(These features already exist in  earlier versions)

Comment 1

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Pull request

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

STR:
1. Disconnect from internet
2. Click on Collection

Expected:
Progress indicator while Collection is initing. Offline message takes it's place.

3. Swipe down notification center and re-enable internet connection.

Expected:
Once connected, progress indicator re-appears. Results take it's place.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8437611 [details] [review]
Pull request

I'm fine if amir reviews this one as he had some comments. After applying your patch I noticed that I did not have icons inside of a smart collection. Just verify that works and I'm happy. Thanks!

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Thanks Kevin, I fixed the grid display by forcing layout. Lmk if you have a better solution.
https://github.com/mozilla-b2g/gaia/pull/20290/files#diff-69eee4fffc909dcb63f98521f692be25R58

Amir, I've pushed a new version as we discussed.

Comment 5

[Amir Nissim (:amirn)]

Comment on attachment 8437611 [details] [review]
Pull request

some more comments on Github (these are the last ones I swear!)

Comment 6

[Amir Nissim (:amirn)]

landed: https://github.com/mozilla-b2g/gaia/commit/eb3a21e6b5fd911ca9847d6a62f9d111dccc0956

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8437611 [details] [review]
Pull request

This is required for the vertical homescreen. We've done our best effort at testing and believe the tree will remain green with uplift.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/a0f537bcdf9f1be9f4097876eeea90b2111c800c

Comment 9

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/ff1100ba2ab8
Build-ID        20141204000228
Version         32.0

Flame v2.1 version:
Gaia-Rev        5655269098c7e82254e56933f1af05b4abe2a2f3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86608c9389b5
Build-ID        20141204001201
Version         34.0