Closed Bug 1020979 Opened 11 years ago Closed 11 years ago

Fix styling on Discover Make Teach on /Resources

Categories

(Webmaker Graveyard :: webmaker.org, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cassie, Assigned: akirose)

References

()

Details

(Whiteboard: [june13][resources])

Attachments

(1 file)

* the circle backgrounds with the icons look irregularly shaped, ie the Make circle is narrower than the Discover circle * circle backgrounds should be @lightgrey – e3eaee to match the circles on the subpages. See https://webmaker.mofostaging.net/en-US/resources/literacy/weblit-Credibility * Ideally, circles should be same size as on subpages. * Also, the page title for this (page name in the tab) still reads 'Explore'. Can we change to Resources? Could file this separately but seems small. Screenshot: http://cl.ly/Vurr Looking in FF 30 / mac Assigning to aki since she built this originally.
Comment on attachment 8437260 [details] [review] https://github.com/mozilla/webmaker.org/pull/784 looks good but the text size needs to be smaller for the icons
Attachment #8437260 - Flags: review?(kate) → review-
Attachment #8437260 - Flags: review- → review?(kate)
Attachment #8437260 - Flags: review?(kate) → review+
Commits pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/064eb096a7ec7d0be99b22c53c8f5e66615db82a Fixes Bug 1020979 - Fix styling on Discover Make Teach on /Resources https://github.com/mozilla/webmaker.org/commit/029b030f354212f817345a2c4f68ba808236d273 Merge pull request #784 from gesa/1020979/circle-fix Bug 1020979 - Fix styling on Discover Make Teach on /Resources
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: