1021032 - make it possible for Balrog to make a request against itself

Status: RESOLVED WONTFIX

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[[e-mail] (:bhearsum)]

In order to support bug 1021029, we'll need Balrog to be able to make a request like it was an HTTP client, but without that overhead. Essentially, I think we need to refactor this class https://github.com/mozilla/balrog/blob/master/auslib/web/views/client.py#L10 so that all of its logic can be called without making an HTTP request.

Comment 1

[[e-mail] (:bhearsum)]

Hmm, we might not even need to refactor anything here. Most of the logic in client.py is about manipulating URLs and headers. We don't need to do that if we're making a request against ourselves, because we already have massaged data. Basically, to make a request against ourself we need to do:
release, update_type = AUS.evaluateRules(query)
AUS.createXML(query, release, update_type)

This may change a bit after bug 1021018 is fixed, but basically, as long as we have access to the "query" object (which we do from anywhere in the request right now), this should be trivial. This may end up being a dupe of bug 1021029.

Comment 2

[[e-mail] (:bhearsum)]

We're going with two separate pings, so we don't need this right now.

Comment 3

[[e-mail] (:bhearsum)]

Won't be needed for awhile.

Comment 4

[[e-mail] (:bhearsum)]

bug 1021029 ended up not being a thing - we went with multiple pings instead. At some point we may look again at returning multiple disparate updates in one response, but there's probably better ways to do this, or at the very least investigated.