1021044 - bustage: widget/windows/winrt/MetroWidget.cpp(1023) : error C2653: 'gfxPrefs' : is not a class or namespace name

Status: VERIFIED FIXED

(Core Graveyard :: Widget: WinRT, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Got a cold so that using sick leaves)]

I cannot build Firefox on Win8.1 (VS 2010) with --enable-metro.

>  5:19.56 a:/mozilla/mc-b/src/widget/windows/winrt/MetroWidget.cpp(1023) : error C2653: 'gfxPrefs' : is not a class or namespace name
>  5:19.56 a:/mozilla/mc-b/src/widget/windows/winrt/MetroWidget.cpp(1023) : error C3861: 'AsyncPanZoomEnabled': identifier not found

Probably, this is a regression of bug 944938.
http://hg.mozilla.org/mozilla-central/rev/9c65721ef16b

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Yeah, probably. I don't have my winrt machine with me at the moment but I can fix this tomorrow if neither you nor markus get to it first.

Comment 2

[Markus Stange [:mstange]]

Sorry about this.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Got a cold so that using sick leaves)]

I'm trying to rebuild after clobber...

Comment 4

[Markus Stange [:mstange]]

Attachment: patch

This should fix it. Can you test?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Got a cold so that using sick leaves)]

Comment on attachment 8435042 [details] [diff] [review]
patch

I can reproduce this after clobber, and I confirmed that this patch fixes this bug. Thanks!

# I hope that this will be pushed m-c directly.

Comment 6

[Markus Stange [:mstange]]

https://hg.mozilla.org/mozilla-central/rev/7297dedf2416

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Got a cold so that using sick leaves)]

-> v. (succeeded to rebuild with the latest m-c)