bustage: widget/windows/winrt/MetroWidget.cpp(1023) : error C2653: 'gfxPrefs' : is not a class or namespace name

VERIFIED FIXED in mozilla32

Status

defect
--
blocker
VERIFIED FIXED
5 years ago
5 months ago

People

(Reporter: masayuki, Assigned: mstange)

Tracking

({regression})

Trunk
mozilla32
x86
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I cannot build Firefox on Win8.1 (VS 2010) with --enable-metro.

>  5:19.56 a:/mozilla/mc-b/src/widget/windows/winrt/MetroWidget.cpp(1023) : error C2653: 'gfxPrefs' : is not a class or namespace name
>  5:19.56 a:/mozilla/mc-b/src/widget/windows/winrt/MetroWidget.cpp(1023) : error C3861: 'AsyncPanZoomEnabled': identifier not found

Probably, this is a regression of bug 944938.
http://hg.mozilla.org/mozilla-central/rev/9c65721ef16b
Yeah, probably. I don't have my winrt machine with me at the moment but I can fix this tomorrow if neither you nor markus get to it first.
Sorry about this.
Posted patch patchSplinter Review
This should fix it. Can you test?
Attachment #8435042 - Flags: review?(masayuki)
Comment on attachment 8435042 [details] [diff] [review]
patch

I can reproduce this after clobber, and I confirmed that this patch fixes this bug. Thanks!

# I hope that this will be pushed m-c directly.
Attachment #8435042 - Flags: review?(masayuki) → review+
https://hg.mozilla.org/mozilla-central/rev/7297dedf2416
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
-> v. (succeeded to rebuild with the latest m-c)
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.