bustage: widget/windows/winrt/MetroWidget.cpp(1023) : error C2653: 'gfxPrefs' : is not a class or namespace name
VERIFIED
FIXED
in mozilla32
Status
()
People
(Reporter: masayuki, Assigned: mstange)
Tracking
({regression})
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
812 bytes,
patch
|
masayuki
:
review+
|
Details | Diff | Splinter Review |
I cannot build Firefox on Win8.1 (VS 2010) with --enable-metro. > 5:19.56 a:/mozilla/mc-b/src/widget/windows/winrt/MetroWidget.cpp(1023) : error C2653: 'gfxPrefs' : is not a class or namespace name > 5:19.56 a:/mozilla/mc-b/src/widget/windows/winrt/MetroWidget.cpp(1023) : error C3861: 'AsyncPanZoomEnabled': identifier not found Probably, this is a regression of bug 944938. http://hg.mozilla.org/mozilla-central/rev/9c65721ef16b
|
||
Comment 1•5 years ago
|
||
Yeah, probably. I don't have my winrt machine with me at the moment but I can fix this tomorrow if neither you nor markus get to it first.
|
(Assignee) | |
Comment 2•5 years ago
|
||
Sorry about this.
|
(Reporter) | |
Comment 3•5 years ago
|
||
I'm trying to rebuild after clobber...
|
|
(Assignee) | |
Comment 4•5 years ago
|
||
Created attachment 8435042 [details] [diff] [review] patch This should fix it. Can you test?
Attachment #8435042 -
Flags: review?(masayuki)
|
|
(Reporter) | |
Comment 5•5 years ago
|
||
Comment on attachment 8435042 [details] [diff] [review] patch I can reproduce this after clobber, and I confirmed that this patch fixes this bug. Thanks! # I hope that this will be pushed m-c directly.
Attachment #8435042 -
Flags: review?(masayuki) → review+
|
|
(Assignee) | |
Comment 6•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7297dedf2416
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
|
|
(Reporter) | |
Comment 7•5 years ago
|
||
-> v. (succeeded to rebuild with the latest m-c)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•