1021061 - Popcorn servers filling up /tmp directory with a lot of random files

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[JP Schneider :jp]

Got an alert on a butter prod server for disk space, and noticed it was /tmp using up all the space (5.5gb on an 8gb volume)

Files were similar to these (though many more, obviously)
-rw-r--r-- 1 root   root       265878 May 21 16:21 8498-1qbcywv.png
-rw-r--r-- 1 root   root       367510 May 21 15:00 8498-1tzuwyq.png
-rw-r--r-- 1 root   root        20128 May 21 15:57 8498-1unn41r.jpg
-rw-r--r-- 1 root   root       146047 May 21 14:13 8498-1wbv3r5.jpg
-rw-r--r-- 1 root   root         1544 May 20 23:02 8498-1wyh8ut.gif
-rw-r--r-- 1 root   root         7879 May 21 13:19 8498-1x3hwvb.jpg
-rw-r--r-- 1 root   root         2535 May 20 23:13 8498-2kcrqh.gif
-rw-r--r-- 1 root   root     28565256 May 21 11:33 8498-9c08v1.avi
-rw-r--r-- 1 root   root       662975 May 21 14:59 8498-fkvnp2.jpg
-rw-r--r-- 1 root   root      1540749 May 21 15:06 8498-k5pdcq.jpg
-rw-r--r-- 1 root   root        20128 May 21 15:53 8498-ny5is3.jpg
-rw-r--r-- 1 root   root       367510 May 21 15:01 8498-qneq4o.png
-rw-r--r-- 1 root   root        37641 May 21 14:20 8498-xbj0yr.jpg
-rw-r--r-- 1 root   root       781960 May 21 15:30 8498-xw5lcx.jpg
drwxr-xr-x 6 root   root         4096 Apr  9 14:38 mozilla.butter

Comment 1

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/549

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/0064a9b0ed502d723b7d99e2157fdb8084367d6c
Fix bug 1021061 - Remove temporary file uploads

Comment 3

[Jon Buckley [:jbuck]]

:jp - Want to verify this is fixed on staging?

Comment 4

[JP Schneider :jp]

Does not seem to be fixed jbuck:

ubuntu@i-de956cfd:/tmp$ ls
7708-16d7weg.jpe  7708-1g41pab.jpe  7708-qnsth3.png  mozilla.butter
ubuntu@i-de956cfd:/tmp$ sudo rm -rf ./*;sudo service butter restart
butter stop/waiting
butter start/running, process 25381
ubuntu@i-de956cfd:/tmp$ ls -l
total 0
ubuntu@i-de956cfd:/tmp$ watch ls -l
ubuntu@i-de956cfd:/tmp$ cd^C
ubuntu@i-de956cfd:/tmp$ ls
mozilla.butter
ubuntu@i-de956cfd:/tmp$ cd mozilla.butter/
ubuntu@i-de956cfd:/tmp/mozilla.butter$ ls
src
ubuntu@i-de956cfd:/tmp/mozilla.butter$ cd src/
ubuntu@i-de956cfd:/tmp/mozilla.butter/src$ ls
butter.js  embed.js
ubuntu@i-de956cfd:/tmp/mozilla.butter/src$

Comment 5

[Jon Buckley [:jbuck]]

This patch just cleans up temporary image files uploaded by users. Those js files are generated by popcorn on every server start, and kinda required for the front-end app to work.

If you try to upload an image to popcorn using the image event upload function, there should be no more images in the temp directory.

Comment 6

[JP Schneider :jp]

Gotcha, then it should be all good!