1021084 - WebAudio should dispatch mozinterruptbegin and mozinterruptend when AudioChannelService mutes the AudioChannelDestination node.

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Andrea Marchesini [:baku]]

Currently HTMLMediaElement dispatches these 2 events and they are useful for ffos apps. We should do something similar in WebAudio as well.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: webaudio.patch

Would like to write a mochitest but I don't know how to make the all document hidden. I tested it changing tabs. Any solution is welcome.

Comment 2

[(no longer active)]

Comment on attachment 8435145 [details] [diff] [review]
webaudio.patch

Review of attachment 8435145 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/AudioDestinationNode.cpp
@@ +435,5 @@
> +  SetCanPlay(playing);
> +
> +  return Context()->DispatchTrustedEvent(
> +           playing ? NS_LITERAL_STRING("mozinterruptend")
> +                   : NS_LITERAL_STRING("mozinterruptbegin"));

Nit: please keep returning NS_OK here.

::: content/media/webaudio/AudioDestinationNode.h
@@ +93,5 @@
>    SelfReference<AudioDestinationNode> mOfflineRenderingRef;
>    uint32_t mFramesToProduce;
>  
>    nsCOMPtr<nsIAudioChannelAgent> mAudioChannelAgent;
> +  bool mAudioChannelAgentPlaying;

Nit: please move this down next to the other two bools for better packing.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: webaudio.patch

https://tbpl.mozilla.org/?tree=Try&rev=e78a9bfee6b8

Comment 4

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=ec43f980e589

https://hg.mozilla.org/integration/mozilla-inbound/rev/87fc79cf3fe1

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/87fc79cf3fe1

Comment 6

[Andrea Marchesini [:baku]]

Comment on attachment 8435294 [details] [diff] [review]
webaudio.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1016277
[User impact if declined]: multiple telephony calls can play audio at the same time.
[Describe test coverage new/current, TBPL]: fully covered.
[Risks and why]: None
[String/UUID change made/needed]: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This landed on m-c prior to the uplift to Aurora (see the Target Milestone, landing date, and the link below), so what's being approved here?
https://hg.mozilla.org/releases/mozilla-aurora/rev/87fc79cf3fe1

Comment 8

[Andrea Marchesini [:baku]]

Ryan, no needs. Thanks.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

CF comment #8. Sorry. I should have checked that.