Closed
Bug 1021114
Opened 10 years ago
Closed 10 years ago
Remove one or other of RootKind::rootKind() and GCMethods::kind()
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
9.17 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
I /think/ RootKind was introduced because GCMethods isn't always available where it's needed. So maybe we can remove this functionality from GCMethods and get rid of the duplication.
|
Assignee | |
Comment 1•10 years ago
|
||
It turns out to be straightforward to remove GCMethods::kind().
Assignee: nobody → jcoppeard
Attachment #8435787 -
Flags: review?(terrence)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8435787 [details] [diff] [review] remove-gcmethods-kind Review of attachment 8435787 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8435787 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f56234ba7ec7
|
||
Comment 4•10 years ago
|
||
Backed out for mochitest-other crashes. https://hg.mozilla.org/integration/mozilla-inbound/rev/6932ea846a28 https://tbpl.mozilla.org/php/getParsedLog.php?id=41274495&tree=Mozilla-Inbound
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/36ec3b142f45
|
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/36ec3b142f45
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•