Closed Bug 1021114 Opened 6 years ago Closed 6 years ago

Remove one or other of RootKind::rootKind() and GCMethods::kind()

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

I /think/ RootKind was introduced because GCMethods isn't always available where it's needed.  So maybe we can remove this functionality from GCMethods and get rid of the duplication.
It turns out to be straightforward to remove GCMethods::kind().
Assignee: nobody → jcoppeard
Attachment #8435787 - Flags: review?(terrence)
Comment on attachment 8435787 [details] [diff] [review]
remove-gcmethods-kind

Review of attachment 8435787 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8435787 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/36ec3b142f45
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.