Closed Bug 1021146 Opened 10 years ago Closed 10 years ago

In-content prefs: remove the border below Popup Policy

Categories

(Firefox :: Settings UI, defect)

All
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 33
Tracking Status
firefox33 --- verified

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(2 files)

Attached image PopupPrivacyGroup.png
Only on OS X there is a border below the Popup Policy option in Content pane. To be consistent in all in-content prefs this border should be removed.
Attached patch noBorder.patchSplinter Review
Remove the border.

I've also removed the no more existing #enableSoftwareInstallRow and #enableImagesRow from browser/themes/osx/preferences/preferences.css.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8435115 - Flags: review?(jaws)
Comment on attachment 8435115 [details] [diff] [review]
noBorder.patch

Review of attachment 8435115 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/osx/preferences/preferences.css
@@ -135,5 @@
>  }
>  
> -#popupPolicyRow,
> -#enableSoftwareInstallRow,
> -#enableImagesRow {

Ok, I see that these two IDs were removed because they were referencing non-existant elements now.
Attachment #8435115 - Flags: review?(jaws) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/49798c4a9850
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Verified fixed on Mac OSX 10.7.5 using latest Nightly 33.0a1 (buildID: 20140624030200).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: