1021146 - In-content prefs: remove the border below Popup Policy

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: PopupPrivacyGroup.png

Only on OS X there is a border below the Popup Policy option in Content pane. To be consistent in all in-content prefs this border should be removed.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: noBorder.patch

Remove the border.

I've also removed the no more existing #enableSoftwareInstallRow and #enableImagesRow from browser/themes/osx/preferences/preferences.css.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8435115 [details] [diff] [review]
noBorder.patch

Review of attachment 8435115 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/osx/preferences/preferences.css
@@ -135,5 @@
>  }
>  
> -#popupPolicyRow,
> -#enableSoftwareInstallRow,
> -#enableImagesRow {

Ok, I see that these two IDs were removed because they were referencing non-existant elements now.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/49798c4a9850

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/49798c4a9850

Comment 6

[Camelia Badau [:cbadau], Release Desktop QA]

Verified fixed on Mac OSX 10.7.5 using latest Nightly 33.0a1 (buildID: 20140624030200).