Closed Bug 1021163 Opened 8 years ago Closed 8 years ago

Animate tab close upwards in horizontal tabs tray

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: Margaret, Assigned: Margaret)

Details

Attachments

(1 file)

Right now we animate tabs closing down, but closing up (flying off the top of the screen) would be better.

Splitting this off from bug 817716.
I'll have to update my patch in bug 817716 to also do this.

Choosing someone besides bnicholson to review my patches :)
Attachment #8435299 - Flags: review?(liuche)
Comment on attachment 8435299 [details] [diff] [review]
Animate tab close upwards in horizontal tabs tray

Review of attachment 8435299 [details] [diff] [review]:
-----------------------------------------------------------------

One thing that I noticed is that on tablets when the tabs are vertical (landscape mode), closing a tab animates the tab to the right, into the content. On phones this doesn't matter because there is no content to either side of the tabs tray in vertical mode - maybe we want to change tabs to animate to the left when in vertical mode?
Attachment #8435299 - Flags: review?(liuche) → review+
(In reply to Chenxia Liu [:liuche] from comment #2)
> Comment on attachment 8435299 [details] [diff] [review]
> Animate tab close upwards in horizontal tabs tray
> 
> Review of attachment 8435299 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> One thing that I noticed is that on tablets when the tabs are vertical
> (landscape mode), closing a tab animates the tab to the right, into the
> content. On phones this doesn't matter because there is no content to either
> side of the tabs tray in vertical mode - maybe we want to change tabs to
> animate to the left when in vertical mode?

Oh yeah, interesting point. I wonder if we want to change this for only tablets, or if we're okay with this for phones, too. I feel like the current behavior just wasn't really thought out.
Flags: needinfo?(ibarlow)
Forgive me for jumping in but!

Maybe we should come up with a different metaphor (not flying off to top/down/left/right) for removing the tab altogether? I can see something less direction dependent like fading away or flipping off (imagine a card standing up and falling down on your desk) to be more forgiving across different devices.

But this might be a whole other discussion all together.
I decided to just land this patch as-is, since it's definitely an improvement: https://hg.mozilla.org/integration/fx-team/rev/ccf56e65739d

We can file a separate bug to discuss more refinements to the tab close animation in general, perhaps as part of or larger tab redesign.
https://hg.mozilla.org/mozilla-central/rev/ccf56e65739d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Flags: needinfo?(ibarlow)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.