1021163 - Animate tab close upwards in horizontal tabs tray

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[:Margaret Leibovic]

Right now we animate tabs closing down, but closing up (flying off the top of the screen) would be better.

Splitting this off from bug 817716.

Comment 1

[:Margaret Leibovic]

Attachment: Animate tab close upwards in horizontal tabs tray

I'll have to update my patch in bug 817716 to also do this.

Choosing someone besides bnicholson to review my patches :)

Comment 2

[Chenxia Liu [:liuche]]

Comment on attachment 8435299 [details] [diff] [review]
Animate tab close upwards in horizontal tabs tray

Review of attachment 8435299 [details] [diff] [review]:
-----------------------------------------------------------------

One thing that I noticed is that on tablets when the tabs are vertical (landscape mode), closing a tab animates the tab to the right, into the content. On phones this doesn't matter because there is no content to either side of the tabs tray in vertical mode - maybe we want to change tabs to animate to the left when in vertical mode?

Comment 3

[:Margaret Leibovic]

(In reply to Chenxia Liu [:liuche] from comment #2)
> Comment on attachment 8435299 [details] [diff] [review]
> Animate tab close upwards in horizontal tabs tray
> 
> Review of attachment 8435299 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> One thing that I noticed is that on tablets when the tabs are vertical
> (landscape mode), closing a tab animates the tab to the right, into the
> content. On phones this doesn't matter because there is no content to either
> side of the tabs tray in vertical mode - maybe we want to change tabs to
> animate to the left when in vertical mode?

Oh yeah, interesting point. I wonder if we want to change this for only tablets, or if we're okay with this for phones, too. I feel like the current behavior just wasn't really thought out.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Forgive me for jumping in but!

Maybe we should come up with a different metaphor (not flying off to top/down/left/right) for removing the tab altogether? I can see something less direction dependent like fading away or flipping off (imagine a card standing up and falling down on your desk) to be more forgiving across different devices.

But this might be a whole other discussion all together.

Comment 5

[:Margaret Leibovic]

I decided to just land this patch as-is, since it's definitely an improvement: https://hg.mozilla.org/integration/fx-team/rev/ccf56e65739d

We can file a separate bug to discuss more refinements to the tab close animation in general, perhaps as part of or larger tab redesign.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ccf56e65739d