don't return nullptr in functions returning bool

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla32
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

No description provided.
Posted patch nullptr.patchSplinter Review
Attachment #8435141 - Flags: review?(jwalden+bmo)
Attachment #8435141 - Flags: review?(bzbarsky)
Comment on attachment 8435141 [details] [diff] [review]
nullptr.patch

r=me on the xpconnect and necko parts.
Attachment #8435141 - Flags: review?(bzbarsky) → review+
Comment on attachment 8435141 [details] [diff] [review]
nullptr.patch

Review of attachment 8435141 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8435141 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/fc756706366d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Posted patch nullptr.patchSplinter Review
there are more nullptr returns where bool is required. breaks mc with 5.1
Attachment #8611263 - Flags: review?(jwalden+bmo)
Attachment #8611263 - Flags: review?(jwalden+bmo) → review+
...that said, please open up new bugs for stuff like this in the future.  Fresh issues not connected to the original bug's genesis get their own fresh bugs.
You need to log in before you can comment on or make changes to this bug.