1021171 - don't return nullptr in functions returning bool

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: nullptr.patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8435141 [details] [diff] [review]
nullptr.patch

r=me on the xpconnect and necko parts.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 8435141 [details] [diff] [review]
nullptr.patch

Review of attachment 8435141 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 4

[Trevor Saunders (:tbsaunde)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc756706366d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fc756706366d

Comment 6

[Franziskus Kiefer [:franziskus]]

Attachment: nullptr.patch

there are more nullptr returns where bool is required. breaks mc with 5.1

Comment 7

[Jeff Walden [:Waldo]]

...that said, please open up new bugs for stuff like this in the future.  Fresh issues not connected to the original bug's genesis get their own fresh bugs.