Closed Bug 1021171 Opened 7 years ago Closed 7 years ago

don't return nullptr in functions returning bool

Categories

(Core :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: tbsaunde, Assigned: tbsaunde)

References

Details

Attachments

(2 files)

No description provided.
Attached patch nullptr.patchSplinter Review
Attachment #8435141 - Flags: review?(jwalden+bmo)
Attachment #8435141 - Flags: review?(bzbarsky)
Comment on attachment 8435141 [details] [diff] [review]
nullptr.patch

r=me on the xpconnect and necko parts.
Attachment #8435141 - Flags: review?(bzbarsky) → review+
Comment on attachment 8435141 [details] [diff] [review]
nullptr.patch

Review of attachment 8435141 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8435141 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/fc756706366d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Attached patch nullptr.patchSplinter Review
there are more nullptr returns where bool is required. breaks mc with 5.1
Attachment #8611263 - Flags: review?(jwalden+bmo)
See Also: → 1166974
Attachment #8611263 - Flags: review?(jwalden+bmo) → review+
...that said, please open up new bugs for stuff like this in the future.  Fresh issues not connected to the original bug's genesis get their own fresh bugs.
You need to log in before you can comment on or make changes to this bug.