1021202 - Turn @media sidebar on by default

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect)

Description

[Heather Arthur [:harth]]

It's useful and doesn't show up for sources w/o @media rules.

Comment 1

[Heather Arthur [:harth]]

Attachment: Set pref to true and update tests

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8435925 [details] [diff] [review]
Set pref to true and update tests

Review of attachment 8435925 [details] [diff] [review]:
-----------------------------------------------------------------

Happy with enabling this by default

::: browser/devtools/styleeditor/test/browser_styleeditor_media_sidebar.js
@@ -4,4 @@
>  
>  // https rather than chrome to improve coverage
>  const TESTCASE_URI = TEST_BASE_HTTPS + "media-rules.html";
> -const PREF = "devtools.styleeditor.showMediaSidebar";

You may want to actually keep this pref around so that you can add a check that the sidebar gets hidden when the pref gets flipped to false

Comment 3

[Heather Arthur [:harth]]

Attachment: To check in

Added a test for hiding the sidebar on pref flip.

Try:
https://tbpl.mozilla.org/?tree=Try&rev=d84a2e9109f7

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/729f6c1413c7

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/729f6c1413c7