Closed Bug 1021263 Opened 7 years ago Closed 7 years ago

Remove ThreadClient.prototype._doInterrupted

Categories

(DevTools :: Debugger, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: fitzgen, Assigned: fitzgen)

Details

Attachments

(1 file)

FWIW it used to be called as part of setBreakpoint, but during some debugging session it must have been left aside instead of fixed directly. My plan was to fix/update it and make all the protocol requests that use that pattern call that instead (setBreakpoint, pauseOnExceptions, pauseOnDOMEvents). I still don't have the time to do that though, so if you are in a hurry just delete it.
Comment on attachment 8435251 [details] [diff] [review]
rm-do-interrupted.patch

(In reply to Panos Astithas [:past] from comment #2)
> FWIW it used to be called as part of setBreakpoint, but during some
> debugging session it must have been left aside instead of fixed directly. My
> plan was to fix/update it and make all the protocol requests that use that
> pattern call that instead (setBreakpoint, pauseOnExceptions,
> pauseOnDOMEvents). I still don't have the time to do that though, so if you
> are in a hurry just delete it.

Would prefer to just delete for now and if you get to those changes, there is always version control and this patch to help you get it back ;)
Attachment #8435251 - Flags: review?(dcamp) → review?(past)
Comment on attachment 8435251 [details] [diff] [review]
rm-do-interrupted.patch

Review of attachment 8435251 [details] [diff] [review]:
-----------------------------------------------------------------

Alright.
Attachment #8435251 - Flags: review?(past) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Assignee: nobody → nfitzgerald
https://hg.mozilla.org/mozilla-central/rev/86c1fa6ff764
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.