Closed
Bug 1021263
Opened 10 years ago
Closed 10 years ago
Remove ThreadClient.prototype._doInterrupted
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file)
|
1.09 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
It's never used. http://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=_doInterrupted&redirect=true
|
Assignee | |
Comment 1•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=c919e3586b52
Attachment #8435251 -
Flags: review?(dcamp)
|
||
Comment 2•10 years ago
|
||
FWIW it used to be called as part of setBreakpoint, but during some debugging session it must have been left aside instead of fixed directly. My plan was to fix/update it and make all the protocol requests that use that pattern call that instead (setBreakpoint, pauseOnExceptions, pauseOnDOMEvents). I still don't have the time to do that though, so if you are in a hurry just delete it.
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8435251 [details] [diff] [review] rm-do-interrupted.patch (In reply to Panos Astithas [:past] from comment #2) > FWIW it used to be called as part of setBreakpoint, but during some > debugging session it must have been left aside instead of fixed directly. My > plan was to fix/update it and make all the protocol requests that use that > pattern call that instead (setBreakpoint, pauseOnExceptions, > pauseOnDOMEvents). I still don't have the time to do that though, so if you > are in a hurry just delete it. Would prefer to just delete for now and if you get to those changes, there is always version control and this patch to help you get it back ;)
Attachment #8435251 -
Flags: review?(dcamp) → review?(past)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8435251 [details] [diff] [review] rm-do-interrupted.patch Review of attachment 8435251 [details] [diff] [review]: ----------------------------------------------------------------- Alright.
Attachment #8435251 -
Flags: review?(past) → review+
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → nfitzgerald
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/86c1fa6ff764
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/86c1fa6ff764
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•