Closed
Bug 1021264
Opened 10 years ago
Closed 10 years ago
Made w/ Code: ship "make a movie poster"
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: matt, Assigned: akirose)
References
Details
(Whiteboard: [madewcode] [june13])
Attachments
(1 file)
Aki: here's the HTML for this one: <h1>Welcome to Webmaker</h1> <strong>Congratulations on your new <a href="http://foo">Made w/Code</a></strong> skills! Now let's learn some <em>HTML</em> and <em>CSS,</em> the languages that make up every page on the web. <h3><b>Make a movie poster</b></h3> <strong> Seen a movie or read any good books lately?</strong> Make a web page with your glowing (or vicious) review. Learn a little code along the way. <h3>Get started</h3> <ul> <li><b>1) Click the "remix" button</b>. This will open Thimble. You'll see a placeholder movie poster to help you get started.</li> <li><b>2) Follow the steps</b>. The tutorial will walk you through how to swap in your own text, images and style.</li> <li><b>3) Done! </b>Once you're finished, just log in to Webmaker and hit "Save."</li> </ul> <h3>Want more?</h3> Webmaker has <a href="http://webmaker.org/gallery">lots of other free activities</a> like this one. Make: https://thimble.webmaker.org/project/21788/remix
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → aki
Reporter | ||
Comment 1•10 years ago
|
||
@ Lainie: I'm working on updating the tutorial text for this one as well https://teach.etherpad.mozilla.org/googleed
Flags: needinfo?(lainie)
Reporter | ||
Comment 2•10 years ago
|
||
@ Aki: this one should be ready for you to implement. Everything you need is in comment 3. * Good to go?
Flags: needinfo?(lainie) → needinfo?(aki)
Assignee | ||
Comment 3•10 years ago
|
||
# Confirming: - Url for this is https://webmaker.org/madewithcode-poster - ID for the make is 5264b700dbf78039360000b7 (raw data can be found at https://makeapi.webmaker.org/api/20130724/make/search?id=5264b700dbf78039360000b7) - The copy for this page is in comment #0 - The design for this page is based on https://redpen.io/ht9394041a025b89e8 # Questions: - Where does that `#foo` link go to? Where is the Made w/code "home" page? - For the first `#foo` link in the markup above—where is that supposed to lead? - For the second `#foo` link above—wouldn’t it make more sense for the anchor text to be `Make a Movie poster`, since that’s the action that would be the result of the click? (FTR, I hear our partner is rather sensitive about these sorts of things)
Status: NEW → ASSIGNED
Flags: needinfo?(aki) → needinfo?(matt)
Reporter | ||
Comment 4•10 years ago
|
||
(In reply to Aki Rose Braun [:akirose] from comment #3) > # Confirming: > > - Url for this is https://webmaker.org/madewithcode-poster > - ID for the make is 5264b700dbf78039360000b7 (raw data can be found at > https://makeapi.webmaker.org/api/20130724/make/ > search?id=5264b700dbf78039360000b7) > - The copy for this page is in comment #0 > - The design for this page is based on https://redpen.io/ht9394041a025b89e8 yes > # Questions: > - Where does that `#foo` link go to? Where is the Made w/code "home" page? * waiting on partner > - For the second `#foo` link above—wouldn’t it make more sense for the > anchor text to be `Make a Movie poster` * Should be "Make a meme" (since this is the "make a movie poster" page)
Flags: needinfo?(matt)
Reporter | ||
Comment 5•10 years ago
|
||
@ Aki: spotted an error in the make. Here's an updated make to use: https://thimble.webmaker.org/project/59709/remix
Flags: needinfo?(aki)
Assignee | ||
Comment 6•10 years ago
|
||
Got it. Updated Make ID is 5398813236745db24d0000be { "makes": [ { "url": "https://openmatt.makes.org/thimble/MTAzODY4MDA2NA==/make-a-movie-poster", "contentType": "application/x-thimble", "contenturl": "https://openmatt.makes.org/thimble/MTAzODY4MDA2NA==/make-a-movie-poster_", "locale": "en-US", "title": "Make a Movie Poster", "description": "Create a movie poster. Learn a little HTML. \nLevel: Intermediate.", "author": "", "published": true, "tags": [ "movieposter", "beginner", "tutorial-https%3A%2F%2Fopenmatt.makes.org%2Fthimble%2FLTEzOTQwODE3OTI%3D%2Ftutorial-for-make-a-movie-poster" ], "thumbnail": "https://stuff.webmaker.org/images/sunset.jpg", "remixedFrom": "5390def32cfa38a87400019c", "likes": [], "reports": [], "remixurl": "https://thimble.webmaker.org/project/59709/remix", "editurl": "https://thimble.webmaker.org/project/59709/edit", "_id": "5398813236745db24d0000be", "createdAt": 1402503474738, "updatedAt": 1402503474738, "username": "openmatt", "emailHash": "586c05a0b9e3a89cc22c20951848657c" } ], "total": 1 }
Flags: needinfo?(aki)
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8440074 -
Flags: review?(kate)
Updated•10 years ago
|
Attachment #8440074 -
Flags: review?(kate) → review+
Comment 8•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/8adfce80863c25a18998736e57a15ca117bd0d42 Fixes Bug 1021264 - Made w/ Code: ship "make a movie poster" https://github.com/mozilla/webmaker.org/commit/ea10eb87aa65c37351523f0424f97777a6c3ef8a Merge pull request #800 from gesa/1021264/mwc-poster Bug 1021264 - Made w/ Code: ship "make a movie poster"
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•