The Comms Icons Need Colour Tweaks for Differentiation

RESOLVED FIXED in Firefox OS v2.0

Status

Firefox OS
Gaia::Homescreen
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: patryk, Assigned: kgrandon)

Tracking

unspecified
2.1 S1 (1aug)
x86
Mac OS X

Firefox Tracking Flags

(b2g-v2.0 fixed, b2g-v2.1 fixed)

Details

(Whiteboard: [systemsfe])

Attachments

(5 attachments, 2 obsolete attachments)

(Reporter)

Description

4 years ago
Created attachment 8435259 [details]
First row of icons

Currently the first 3 icons are all the same colour and its hard to see the difference.
Perhaps Phone needs to be more green.
SMS needs to be more blue.
(Reporter)

Updated

4 years ago
Assignee: nobody → pla
Blocks: 989848
(Assignee)

Comment 1

4 years ago
When will we have these? I'm not sure what kind of blocking criteria we will have for 2.0, so we would ideally have these assets today if we want to include them.
Blocks: 1017954
No longer blocks: 989848

Updated

4 years ago
QA Whiteboard: [VH-FL-blocking-]

Comment 2

4 years ago
Created attachment 8459063 [details]
FFOS2CommsAppIconUpdate_July18.zip

Hi Kevin,

Here are the new Comms icons with greater separation of colour.  I'm going to assign it to you now.

Thanks again!

Updated

4 years ago
Assignee: pla → kgrandon
(Assignee)

Updated

4 years ago
Attachment #8459132 - Attachment is obsolete: true
(Assignee)

Comment 4

4 years ago
Created attachment 8459133 [details]
Pull request - Update contacts app icons
(Assignee)

Comment 5

4 years ago
Created attachment 8459134 [details] [review]
Pull request - Update contacts app icons
Attachment #8459133 - Attachment is obsolete: true
(Assignee)

Comment 6

4 years ago
Comment on attachment 8459134 [details] [review]
Pull request - Update contacts app icons

Francisco - could you take a look if you have time? Thanks!
Attachment #8459134 - Flags: review?(francisco)
(Assignee)

Comment 7

4 years ago
Created attachment 8459135 [details] [review]
Pull request - Update dialer app icons

Etienne - Could you take a look if you have time? Thanks!
Attachment #8459135 - Flags: review?(etienne)
(Assignee)

Comment 8

4 years ago
Created attachment 8459136 [details] [review]
Pull request - Update messages app icons

Julien - could you take a look if you have time? Thanks!
Attachment #8459136 - Flags: review?(felash)
Comment on attachment 8459136 [details] [review]
Pull request - Update messages app icons

r=me but you need to optimize the png files before merging. optipng (which I think is even not the best) could decrease the file size from 15% to 20% depending on the file, this is good to take IMO :)
Attachment #8459136 - Flags: review?(felash) → review+
Attachment #8459135 - Flags: review?(etienne) → review?(anthony)
(Assignee)

Comment 10

4 years ago
(In reply to Julien Wajsberg [:julienw] from comment #9)
> Comment on attachment 8459136 [details] [review]
> Pull request - Update messages app icons
> 
> r=me but you need to optimize the png files before merging. optipng (which I
> think is even not the best) could decrease the file size from 15% to 20%
> depending on the file, this is good to take IMO :)

Good point, forgot about this. Will update these patches.
Comment on attachment 8459134 [details] [review]
Pull request - Update contacts app icons

Thanks Kevin!
Attachment #8459134 - Flags: review?(francisco) → review+
Comment on attachment 8459135 [details] [review]
Pull request - Update dialer app icons

We even have tools/png_recompress.sh to do so.
Attachment #8459135 - Flags: review?(anthony) → review+
(Assignee)

Updated

4 years ago
Blocks: 989848
No longer blocks: 1017954
(Assignee)

Comment 14

4 years ago
Comment on attachment 8459134 [details] [review]
Pull request - Update contacts app icons

Would like to request approval for 2.0 with the patches from these three bugs. All three patches are icons only and extremely low risk which give us some additional visual polish for the vertical homescreen.
Attachment #8459134 - Flags: approval-gaia-v2.0?(bbajaj)
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S6 (18july)
QA Whiteboard: [VH-FL-blocking-] → [VH-FL-blocking-][VH-FC-blocking-]
Attachment #8459134 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Needs rebasing for v2.0 uplift.
status-b2g-v2.0: --- → affected
status-b2g-v2.1: --- → fixed
Flags: needinfo?(kgrandon)
Target Milestone: 2.0 S6 (18july) → 2.1 S1 (1aug)
(Assignee)

Comment 16

4 years ago
Squashed and uplifted: https://github.com/mozilla-b2g/gaia/commit/1bca63303bada6b53c0e50bc466c2a7d9d0a27a7
status-b2g-v2.0: affected → fixed
Flags: needinfo?(kgrandon)
You need to log in before you can comment on or make changes to this bug.