JIT pseudostack frames do not have copy flag set

RESOLVED FIXED in mozilla32

Status

()

Core
Gecko Profiler
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

unspecified
mozilla32
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
JIT pseudostack frames have non-static labels and should have the copy flag set.
(Assignee)

Comment 1

4 years ago
Created attachment 8435265 [details] [diff] [review]
Use copy flag for JIT pseudostack frames (v1)

Fix the line number for the entry frame and fix the copy flags for the two JIT frames.
Attachment #8435265 - Flags: review?(vporof)
Comment on attachment 8435265 [details] [diff] [review]
Use copy flag for JIT pseudostack frames (v1)

This looks ok to me, but Kannan would be a better reviewer for this.
Can you please explaing why these need to have the copy label set *now*? Did they have the copy label set before and bug 1004726 regressed this?
Attachment #8435265 - Flags: review?(vporof) → review?(kvijayan)
(Assignee)

Comment 3

4 years ago
(In reply to Victor Porof [:vporof][:vp] from comment #2)
> Comment on attachment 8435265 [details] [diff] [review]
> Use copy flag for JIT pseudostack frames (v1)
> 
> This looks ok to me, but Kannan would be a better reviewer for this.
> Can you please explaing why these need to have the copy label set *now*? Did
> they have the copy label set before and bug 1004726 regressed this?

Right. The flag used to be a "no copy" flag and it was *not* set. Now it's a "copy" flag and it should be set.
(Assignee)

Comment 4

4 years ago
IMO the current "copy" flag is more clear than before. We just have to be careful to set it :)

Updated

4 years ago
Attachment #8435265 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/mozilla-central/rev/bebb2a8b8f83
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.