So the acknowledgment email you get when you receive a badge has inline html which isn't rendering for me in gmail, so imagine many users see this: https://www.evernote.com/shard/s230/sh/42153c9d-33c1-4c93-9a37-2f5f09f7091a/1aea4cb37d18f47bbf25f734e90c5f85 As you can see above this also doesn't provide a link to the mentors profile properly. I'd suggest simply changing this to "Congratulations! You earned the Webmaker Super Mentor badge (https://webmaker.mofostaging.net/badges/webmaker-super-mentor_. You can view it now on your profile page (link to profile).
Yeah, that sounds like a good idea
Created attachment 8435818 [details] [review] https://github.com/mozilla/node-webmaker-postalservice/pull/14 Will need a sawmill update
Comment on attachment 8435818 [details] [review] https://github.com/mozilla/node-webmaker-postalservice/pull/14 Isn't the problem here that nunjucks is escaping that HTML? I see you used the safe filter though, so I'm not sure what's up with that...
Attachment #8435818 - Flags: review?(jon) → review-
Created attachment 8440738 [details] [review] https://github.com/mozilla/node-webmaker-postalservice/pull/16
Assignee: kate → jon
Status: NEW → ASSIGNED
Attachment #8440738 - Flags: review?(kate)
Comment on attachment 8435818 [details] [review] https://github.com/mozilla/node-webmaker-postalservice/pull/14 >https://github.com/mozilla/node-webmaker-postalservice/pull/14
Attachment #8435818 - Attachment is obsolete: true
Attachment #8440738 - Flags: review?(kate) → review+
Commit pushed to master at https://github.com/mozilla/node-webmaker-postalservice https://github.com/mozilla/node-webmaker-postalservice/commit/3f049be4ed329818b4283c4b0fb70de750181158 Fix bug 1021300 - Don't escape HTML in email
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.