Closed
Bug 1021300
Opened 10 years ago
Closed 10 years ago
Remove href on super mentor badge
Categories
(Webmaker Graveyard :: Communications, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: brett, Assigned: jon)
Details
Attachments
(1 file, 1 obsolete file)
So the acknowledgment email you get when you receive a badge has inline html which isn't rendering for me in gmail, so imagine many users see this: https://www.evernote.com/shard/s230/sh/42153c9d-33c1-4c93-9a37-2f5f09f7091a/1aea4cb37d18f47bbf25f734e90c5f85 As you can see above this also doesn't provide a link to the mentors profile properly. I'd suggest simply changing this to "Congratulations! You earned the Webmaker Super Mentor badge (https://webmaker.mofostaging.net/badges/webmaker-super-mentor_. You can view it now on your profile page (link to profile).
Comment 1•10 years ago
|
||
Yeah, that sounds like a good idea
Comment 2•10 years ago
|
||
Will need a sawmill update
Updated•10 years ago
|
Attachment #8435818 -
Flags: review?(jon)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8435818 [details] [review] https://github.com/mozilla/node-webmaker-postalservice/pull/14 Isn't the problem here that nunjucks is escaping that HTML? I see you used the safe filter though, so I'm not sure what's up with that...
Attachment #8435818 -
Flags: review?(jon) → review-
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8435818 [details] [review] https://github.com/mozilla/node-webmaker-postalservice/pull/14 >https://github.com/mozilla/node-webmaker-postalservice/pull/14
Attachment #8435818 -
Attachment is obsolete: true
Updated•10 years ago
|
Attachment #8440738 -
Flags: review?(kate) → review+
Comment 6•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/node-webmaker-postalservice https://github.com/mozilla/node-webmaker-postalservice/commit/3f049be4ed329818b4283c4b0fb70de750181158 Fix bug 1021300 - Don't escape HTML in email
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•