1021367 - Assertion failure in GetShaderConfigFor

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Douglas Crosher [:dougc]]

Running the BananaBench asm.js demo on a Nexus 7 (older model), Android 4.4, crashes on the following assertion:

gfx/layers/opengl/CompositorOGL.cpp:907
907	    MOZ_ASSERT_IF(source->GetTextureTarget() == LOCAL_GL_TEXTURE_EXTERNAL,
908	                  source->GetFormat() == gfx::SurfaceFormat::R8G8B8A8);

Comment 1

[Douglas Crosher [:dougc]]

fwiw this assertion was added in Bug 926128.

Comment 2

[Douglas Crosher [:dougc]]

Attachment: hack patch for the Nexus 4

I am having trouble reproducing this on the Nexus 7 using the current m-c, perhaps some other regression over the last week. The demo now just stops, like there is a deadlock in the graphics pipe, but other tabs can be opened.

However I got a similar failure on a Nexus 4:
Assertion failure: source->GetFormat() == gfx::SurfaceFormat::R8G8B8A8, at gfx/layers/opengl/CompositorOGL.cpp:926

The unexpected value of source->GetFormat() on the Nexus 4 is R8G8B8X8, and adding this at least allows the demo to proceed.

Comment 3

[Douglas Crosher [:dougc]]

Got it running again on the Nexus 7. Upgraded to 4.4.3 and did a clean install of Firefox, and perhaps this helped. The demo causes exactly the same failure on the Nexus 7 as the Nexus 4, and the same patch gets it running.

Comment 4

[Douglas Crosher [:dougc]]

Attachment: Backport for beta (31)

This issue might also affect beta. Would anyone have time to look at this?

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8436844 [details] [diff] [review]
hack patch for the Nexus 4

Review of attachment 8436844 [details] [diff] [review]:
-----------------------------------------------------------------

Nical, is this fix correct? This crash is showing up on https://tbpl.mozilla.org/?tree=Try&rev=64cb0111f38c and if it's easy to fix we should do that.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e394d04ba98a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e394d04ba98a