1021443 - java.lang.IllegalStateException: Already registered Webapps:Postinstall under a different type

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Richard Newman [:rnewman]]

I get this during installation.

I/GeckoWebappInstallListener(27136): Downloaded APK file deleted
D/GeckoProfile(27136): Created new profile dir.
E/GeckoAppShell(27136): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 3762 ("GeckoBackgroundThread")
E/GeckoAppShell(27136): java.lang.IllegalStateException: Already registered Webapps:Postinstall under a different type
E/GeckoAppShell(27136): 	at org.mozilla.gecko.EventDispatcher.checkNotRegistered(EventDispatcher.java:86)
E/GeckoAppShell(27136): 	at org.mozilla.gecko.EventDispatcher.registerGeckoThreadListener(EventDispatcher.java:125)
E/GeckoAppShell(27136): 	at org.mozilla.gecko.webapp.InstallHelper.registerGeckoListener(InstallHelper.java:153)
E/GeckoAppShell(27136): 	at org.mozilla.gecko.webapp.InstallHelper.access$000(InstallHelper.java:30)
E/GeckoAppShell(27136): 	at org.mozilla.gecko.webapp.InstallHelper$1.run(InstallHelper.java:60)
E/GeckoAppShell(27136): 	at android.os.Handler.handleCallback(Handler.java:733)
E/GeckoAppShell(27136): 	at android.os.Handler.dispatchMessage(Handler.java:95)
E/GeckoAppShell(27136): 	at android.os.Looper.loop(Looper.java:136)
E/GeckoAppShell(27136): 	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:32)

Comment 1

[Richard Newman [:rnewman]]

And then it happens on launch, too:

E/GeckoAppShell(27290): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
E/GeckoAppShell(27290): java.lang.IllegalStateException: Already registered Webapps:Postinstall under a different type
E/GeckoAppShell(27290): 	at org.mozilla.gecko.EventDispatcher.checkNotRegistered(EventDispatcher.java:86)
E/GeckoAppShell(27290): 	at org.mozilla.gecko.EventDispatcher.registerGeckoThreadListener(EventDispatcher.java:110)
E/GeckoAppShell(27290): 	at org.mozilla.gecko.webapp.EventListener.registerEvents(EventListener.java:49)
E/GeckoAppShell(27290): 	at org.mozilla.gecko.GeckoApp.onWindowFocusChanged(GeckoApp.java:1997)
E/GeckoAppShell(27290): 	at com.android.internal.policy.impl.PhoneWindow$DecorView.onWindowFocusChanged(PhoneWindow.java:2647)
E/GeckoAppShell(27290): 	at android.view.View.dispatchWindowFocusChanged(View.java:7900)
E/GeckoAppShell(27290): 	at android.view.ViewGroup.dispatchWindowFocusChanged(ViewGroup.java:968)
E/GeckoAppShell(27290): 	at android.view.ViewRootImpl$ViewRootHandler.handleMessage(ViewRootImpl.java:3140)
E/GeckoAppShell(27290): 	at android.os.Handler.dispatchMessage(Handler.java:102)
E/GeckoAppShell(27290): 	at android.os.Looper.loop(Looper.java:136)
E/GeckoAppShell(27290): 	at android.app.ActivityThread.main(ActivityThread.java:5017)
E/GeckoAppShell(27290): 	at java.lang.reflect.Method.invokeNative(Native Method)
E/GeckoAppShell(27290): 	at java.lang.reflect.Method.invoke(Method.java:515)
E/GeckoAppShell(27290): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
E/GeckoAppShell(27290): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
E/GeckoAppShell(27290): 	at dalvik.system.NativeStart.main(Native Method)

Comment 2

[Richard Newman [:rnewman]]

Attachment: Use NativeEventListener in webapps. v1

This makes the problem go away.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8435465 [details] [diff] [review]
Use NativeEventListener in webapps. v1

Review of attachment 8435465 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks!

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/1c4cdf7294f4

Bug 989046 landed in 31, so my guess is that this needs to be uplifted.

Comment 5

[Richard Newman [:rnewman]]

Backed out 'cos it depends on the refactoring in Bug 1021342.

https://hg.mozilla.org/integration/fx-team/rev/d54d7a3105b6

Comment 6

[Aaron Train [:aaronmt]]

Isn't this a duplicate of bug 1020926 which has patches on it already?

Comment 7

[Richard Newman [:rnewman]]

Huh, good job Bugzilla for not suggesting that bug :)

I think this is the correct fix. Parts of the work on that bug might apply too, but this is (a) necessary (the old approach is deprecated), (b) fixes the problem, so...

Comment 8

[Richard Newman [:rnewman]]

Changed my mind on waiting for the refactor.

https://hg.mozilla.org/integration/fx-team/rev/7331dd991a5c

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Note to self: request uplift for bug 985614 after we request uplift for this bug.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7331dd991a5c

Comment 11

[Richard Newman [:rnewman]]

Comment on attachment 8435465 [details] [diff] [review]
Use NativeEventListener in webapps. v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Bug 989046.

User impact if declined: 
  Unable to use installed webapps. Blocks landing of Bug 985614.

Testing completed (on m-c, etc.): 
  Baked in Nightly, verified by hand, now rolled into Aurora.

Risk to taking this patch (and alternatives if risky): 
  Theoretical risk of different behavior between NativeJSObject and JSONObject (small). No real alternative.

String or IDL/UUID changes made by this patch:
  None.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3a3631ee360f

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage.
https://hg.mozilla.org/releases/mozilla-beta/rev/606b5a1e4ac6

https://tbpl.mozilla.org/php/getParsedLog.php?id=41456392&tree=Mozilla-Beta

Comment 14

[Richard Newman [:rnewman]]

Off the bat, this has a dependency on Bug 1004073, and all of its dependencies -- NativeEventListener made it into 31, but the EventDispatcher changes that came with it only got into 32.

I'll take a look at the patch, see if it can easily be reworked.

Comment 15

[Richard Newman [:rnewman]]

Attachment: Beta patch. v1

I attempted to manually translate the event listener calls as they apply on Beta.

Jim, did I get this right?

It builds, but I haven't tested yet. (I'm on PTO but I'm not very good at it.)

Comment 16

[(inactive) Jim Chen [:jchen] [:darchons]]

Are we using NativeEventListener for "Webapps:Postinstall" on Beta? Seems like we still use GeckoEventListener [1]. If so, we don't need to make the switch here.

[1] http://hg.mozilla.org/releases/mozilla-beta/file/tip/mobile/android/base/webapp/EventListener.java#l41

Comment 17

[Richard Newman [:rnewman]]

I can't reproduce this bug from my mozilla-beta tree. I can repro Bug 985614.