1021466 - Make it possible to pass in an nsITabParent when opening windows, and then stash that nsITabParent in the newly created chrome docshell

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Splitting this work off from bug 989501.

The patches I'm posting were originally written and reviewed in bug 989501. They're ready to land now, whereas the rest of that bug is not.

So this bug is just about landing infrastructure stuff that bug 989501 will need when it's ready to land, and we want to avoid bitrot.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Part 1: Make it possible to stash opener and newly created TabParent's inside DocShell.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Part 1: Make it possible to stash opener and newly created TabParent's inside DocShell.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8435473 [details] [diff] [review]
Part 1: Make it possible to stash opener and newly created TabParent's inside DocShell.

Addressed review comments from smaug from https://bugzilla.mozilla.org/show_bug.cgi?id=989501#c51.

I didn't switch to using attribute since [notxpcom] doesn't allow it, so after discussing with smaug in IRC, just added documentation explaining that in nsIDocShell.idl.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Part 2: Make it possible to pass in an nsITabParent when opening windows, and then stash that nsITabParent in the newly created chrome docshell.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8435475 [details] [diff] [review]
Part 2: Make it possible to pass in an nsITabParent when opening windows, and then stash that nsITabParent in the newly created chrome docshell.

r+'d by smaug in bug 989501 (attachment #8430351 [details] [diff] [review]).

Comment 6

[Mike Conley (:mconley) (:⚙️)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/522ef2feb676
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/ad9adc4900df

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/522ef2feb676
https://hg.mozilla.org/mozilla-central/rev/ad9adc4900df

Comment 8

[(no longer active)]

Mike, is any code still using nsIDocShell::get/setOpener?  I can't find any consumers, and if so we can remove all of this infrastructure...

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Yes.

GetOpener is used here: https://dxr.mozilla.org/mozilla-central/rev/f14898695ee0dd14615914f3e1401f17df57fdd7/dom/base/nsFrameLoader.cpp#2303

SetOpener is used here: https://dxr.mozilla.org/mozilla-central/rev/f14898695ee0dd14615914f3e1401f17df57fdd7/xpfe/appshell/nsWebShellWindow.cpp#189

Comment 10

[(no longer active)]

Oh, thanks!  DXR was failing me!