Closed Bug 1021466 Opened 6 years ago Closed 6 years ago

Make it possible to pass in an nsITabParent when opening windows, and then stash that nsITabParent in the newly created chrome docshell

Categories

(Core :: DOM: Core & HTML, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32
Tracking Status
e10s + ---

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(2 files, 1 obsolete file)

Splitting this work off from bug 989501.

The patches I'm posting were originally written and reviewed in bug 989501. They're ready to land now, whereas the rest of that bug is not.

So this bug is just about landing infrastructure stuff that bug 989501 will need when it's ready to land, and we want to avoid bitrot.
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Comment on attachment 8435473 [details] [diff] [review]
Part 1: Make it possible to stash opener and newly created TabParent's inside DocShell.

Addressed review comments from smaug from https://bugzilla.mozilla.org/show_bug.cgi?id=989501#c51.

I didn't switch to using attribute since [notxpcom] doesn't allow it, so after discussing with smaug in IRC, just added documentation explaining that in nsIDocShell.idl.
Attachment #8435473 - Flags: review+
Comment on attachment 8435475 [details] [diff] [review]
Part 2: Make it possible to pass in an nsITabParent when opening windows, and then stash that nsITabParent in the newly created chrome docshell.

r+'d by smaug in bug 989501 (attachment #8430351 [details] [diff] [review]).
Attachment #8435475 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/522ef2feb676
https://hg.mozilla.org/mozilla-central/rev/ad9adc4900df
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Mike, is any code still using nsIDocShell::get/setOpener?  I can't find any consumers, and if so we can remove all of this infrastructure...
Flags: needinfo?(mconley)
Oh, thanks!  DXR was failing me!
You need to log in before you can comment on or make changes to this bug.