1021494 - Fix a compiler error with clang-cl in nsScriptableInputStream.cpp

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Comment 1

[(no longer active)]

Attachment: Fix a compiler error with clang-cl in nsScriptableInputStream.cpp

Comment 2

[(no longer active)]

Comment on attachment 8435501 [details] [diff] [review]
Fix a compiler error with clang-cl in nsScriptableInputStream.cpp

I guess clang-cl actually expects to see C++... ;)

Comment 3

[Masatoshi Kimura [:emk]]

Why the first cast is C style (|(uint32_t)XPCOM_MIN...|) while the second cast is function-style (|uint32_t(UINT32_MAX - 1)|)?

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8435501 [details] [diff] [review]
Fix a compiler error with clang-cl in nsScriptableInputStream.cpp

Review of attachment 8435501 [details] [diff] [review]:
-----------------------------------------------------------------

For posterity: Ehsan and I discussed this on IRC, and UINT32_MAX appears to be defined via MS extensions as 0xffffffffui32.  Apparently clang-cl's support of this extension is incomplete, so it requires the explicit cast to uint32_t.

I think this is unfortunate, but I suppose it's OK.  Just so we don't have a proliferation of these. ;)

Comment 5

[(no longer active)]

(In reply to Masatoshi Kimura [:emk] from comment #3)
> Why the first cast is C style (|(uint32_t)XPCOM_MIN...|) while the second
> cast is function-style (|uint32_t(UINT32_MAX - 1)|)?

Because they were written by different people.  But since my cast is always better, I fixed the other one.  ;-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5232023af37

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f5232023af37

Comment 7

[(no longer active)]

Backed out because the upstream bug was fixed: https://hg.mozilla.org/integration/mozilla-inbound/rev/740c7ba3d181