Closed Bug 1021533 Opened 10 years ago Closed 10 years ago

Follow up to bug 1018836 - fadeout class cleanup

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

x86
macOS
defect
Not set
normal

Tracking

(b2g-v2.0 fixed)

RESOLVED FIXED
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: etienne, Assigned: etienne)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
When going back to the homescreen from a landscape app, we do an immediate transition.
This now implies that the HomescreeWindow goes from immediate-open to opened without going through opening (logic since it's immediate :)).

Anyway we never get a chance to call .fadeIn() (it's in the do__opening), so I this patch is adding the css class "fadeout" to the classes to cleanup.
Blocks: 1018836
Nice call. Also we can do fadein in opened I believe. but whatever your thought is also ok.
Attached file Gaia PR
Assignee: nobody → etienne
Attachment #8435545 - Flags: review?(alive)
Attachment #8435545 - Flags: review?(alive) → review+
https://github.com/mozilla-b2g/gaia/commit/131c5cce4afe158b1db0be58f980130ccc1ab34a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: