1021569 - rewrite clear-stage-app in javascript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

somethings rule "clear-stage-app" is really slow on Windows and we should integrate it into pre-app which Alex are working on bug 1021051

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

before: 8.453s
after: 11.130s

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: github PR: https://github.com/mozilla-b2g/gaia/pull/20128

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

travis: 
https://travis-ci.org/mozilla-b2g/gaia/builds/26920997

try server:
https://tbpl.mozilla.org/?tree=Gaia-Try&rev=397c66cffeb1

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

forgot commit Makefile, push to try and travis again.

travis: 
https://travis-ci.org/mozilla-b2g/gaia/builds/26921194

try:
https://tbpl.mozilla.org/?tree=Gaia-Try&rev=3919a7f3b631

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

reduce ~1 second on mac.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8435599 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/20128

George, could you review this pr? thanks!

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8435599 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/20128

Looks good! Thanks.
r=gduan

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

looks good on try server.
https://tbpl.mozilla.org/?tree=Gaia-Try&rev=0cea076515fafd6282d2d674748cc0b27f13e51b

merged.
https://github.com/mozilla-b2g/gaia/commit/ac3d4915e4a86af73ccb9c23129af82e23f8392f