1021583 - [dolphin][Flame][Camera][v1.4] The Camera Interface display abnormal after share pictures to email in landscape mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[yong.ren]

Attachment: Camera_display_abnormal.png

DEFECT DESCRIPTION:
  The Camera Interface display abnormal after share pictures to email in landscape mode 

Steps to reproduce:
----------------------------------------------------
 All operations below are done under the landscape mode

1. Enter Camera, take a photograph
2. click the photograph Thumbnail which is on the left side of capture button. 
3. click the share button and choose Email in share interface
4. the confirmation interface will popup when you are not set up email account, choose "cancel"。

Actual result:
---------------------------------------
The Camera Interface display abnormal 


Expected result:
--------------------------------------- 
The Camera interface display normal 


Additional info:
--------------------------------------
Reproduce rate:  5/5

Comment 1

[Steven Yang [:styang]]

Hi Peipei,
Could you double check it on Flame? thanks.

Comment 2

[Peipei Cheng (needinfo if you need my action)]

(In reply to Steven Yang [:styang] from comment #1)
> Hi Peipei,
> Could you double check it on Flame? thanks.

Yes. I reproduced on Flame v1.4. Here is what I saw:

4. the confirmation interface will popup when you are not set up email account, choose "cancel"。
   --> After clicking "Cancel", the page returns to picture preview, but half of this screen shows wallpaper. And then it returns to Camera quickly.

But if I select Share to Bluetooth, the preview page will show in portrait mode all the time.

Comment 3

[Preeti Raghunath(:Preeti)]

Hema

This seems to block for 1.4 with Dolphin. Please review.

Comment 4

[Hema Koka [:hema]]

Justin, Can you investigate this one and check if it is a camera issue?

Comment 5

[Jason Smith [:jsmith]]

QA Wanted to check 1.3.

Comment 6

[Justin D'Arcangelo [:justindarc]]

(In reply to Hema Koka [:hema] from comment #4)
> Justin, Can you investigate this one and check if it is a camera issue?

I was able to consistently reproduce on v1.4 but not v2.0. This issue sounds vaguely familiar though but I can't seem to find a bug number for it. Anyhow, this appears to be a Window Mgmt issue.

Comment 7

[yong.ren]

(In reply to Hema Koka [:hema] from comment #4)
> Justin, Can you investigate this one and check if it is a camera issue?

Hi Hema:

Gallery also have the problem.

steps to reproduce:

  under the landscape mode

1. Enter gallery, click a picture
2. click the share button and choose Email in share interface
3. the confirmation interface will popup when you are not set up email account, choose "cancel"。
 
  Now change to the portrait mode

4. click the share button and choose Email in share interface
5. the confirmation interface will popup when you are not set up email account, choose "cancel"。

The gallery will display abnormal right now。

Comment 8

[yong.ren]

(In reply to Jason Smith [:jsmith] from comment #5)
> QA Wanted to check 1.3.

Hi Jason:

   v1.3 don't have this issue。

   and the share Activity don't have the landscape mode in v1.3. but in v1.4  it did.

   is it related with the problem?

Comment 9

[Keven Kuo [:kkuo]]

Hi! Hema,

Could someone help on this case? Thanks

--
Keven

Comment 10

[Mike Habicher [:mikeh] (high bugzilla latency)]

Changing component to reflect comment 6.

I am also unable to reproduce this with v2.1/master.

Comment 11

[Hema Koka [:hema]]

(In reply to Keven Kuo [:kkuo] from comment #9)
> Hi! Hema,
> 
> Could someone help on this case? Thanks
> 
> --
> Keven

Keven,

This looks like a window management issue though it manifests on camera...mike moved it to the right component -- Tim/Alive probably are the right people to take a look at this. 

Thanks
Hema

Comment 12

[thomas tsai]

Hi Alive: can you help?

Comment 13

[Roland Kunkel [:RolandK]]

(In reply to Jason Smith [:jsmith] from comment #5)
> QA Wanted to check 1.3.

This issue does NOT reproduce in the latest Buri 1.3 build

Environmental Variables:
Device: Buri 1.3
BuildID: 20140613024000
Gaia: 8d6bd6c484557c5322bf14798a4273d2a8f4300f
Gecko: d0c6d2ebfe65
Version: 28.0
Firmware Version: V1.2-device.cfg

-

The issue does NOT reproduce on the latest Open_C Base Image:

Environmental Variables:
Device: Open_C
BuildID: 20140505052400
Version: 28.0
Firmware Version: P821A10v1.0.0B06_LOG_DL



- Providing the rest of the branch information - 

This issue does NOT reproduce in the latest Flame 2.0 build:

Environmental Variables:
Device: Flame 2.0
BuildID: 20140613000203
Gaia: a3a5322692578e0a577fb7fa08e32144b2b05ba3
Gecko: 8897bc43f59b
Version: 32.0a2
Firmware Version: V121-G

-

This issue does NOT reproduce on the latest Flame 2.1 build:

Environmental Variables:
Device: Flame 2.1
BuildID: 20140612040203
Gaia: 41db6954a67efc55016744bc8f6591ae9e07a285
Gecko: 9e8e3e903484
Version: 33.0a1
Firmware Version: V121-G

-

The issue DOES reproduce on the latest v1.4 Buri build:

Environmental Variables:
Device: Buri 1.4
BuildID: 20140612000202
Gaia: 7fc73d4cb1bece31f50e8ccf6fb98af3984a9ebf
Gecko: bcd308fbbf38
Version: 30.0
Firmware Version: V1.2-device.cfg

-

This issue DOES reproduce on the latest v1.4 Open_C build:

Environmental Variables:
Device: Open_C 1.4
BuildID: 20140612000202
Gaia: 7fc73d4cb1bece31f50e8ccf6fb98af3984a9ebf
Gecko: bcd308fbbf38
Version: 30.0
Firmware Version: P821A10v1.0.0B06_LOG_DL

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: patch for 1.4

The root cause is the active app is still email while gallery app calles resize after it opened. And statusbar will check active app of AWM to decide its height (this is bad but we cannot fix it now). I think this is also reproducible on 2.0+ so I am going to write another patch for 2.0

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: pat

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

2.1 https://github.com/mozilla-b2g/gaia/commit/646efa07944adfe96c28d6075f95be1037eb657c
1.4 https://github.com/mozilla-b2g/gaia/commit/fc74015d26bcbc3e31a45d34cb65777112a35982

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/aa0e805d63d82951c8e040ae7e270e205415e251

Next time, please just do the v2.0 push while you're at it :)

Comment 18

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #17)
> v2.0:
> https://github.com/mozilla-b2g/gaia/commit/
> aa0e805d63d82951c8e040ae7e270e205415e251
> 
> Next time, please just do the v2.0 push while you're at it :)

I am told that push on my own will make your work tough, am I wrong? Are we supposed to push to 2.0 on our own from now on?

Comment 19

[Yeojin Chung [:YeojinC]]

New test case needs to be added. There is no existing test case.

Comment 20

[KTucker [:KTucker][Inactive 3/4/2016]]

Test case has been added to moztrap:

https://moztrap.mozilla.org/manage/case/14351/

Comment 21

[sarsenyev]

Verified the issue is fixed on 2.1, 2.0 and 1.4

After canceling "Share via email" the user is returned to the camera screen, Camera screen displays normally 

Device: Flame 2.1 KK
BuildID: 20141103001220
Gaia: 027a7de0c95320cea0579bfd1a4ceef3e9038f34
Gecko: ffecb2be228b
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Device: Flame 2.0 KK
BuildID: 20141103000201
Gaia: 7b8df9941700c1f6d6d51ff464f0c8ae32008cd2
Gecko: 82a6ed695964
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
  
Device: Flame 1.4
BuildID: 20141031003004
Gaia: 9ff9ee9e56ba04aff6900f872535cd8f3aee7904
Gecko: 6f76cb0d1d05
Gonk: 
Version: 30.0 (1.4)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0