1021664 - Revert patch for homebutton handling while Collection is open

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Amir Nissim (:amirn)]

Now that bug 1016334 has landed, we no longer need to handle homebutton taps.

Comment 1

[Amir Nissim (:amirn)]

Attachment: PR

Reverts:
https://github.com/EverythingMe/gaia/commit/9a96c657a57956dd7f5cab74d06bf44b5131f402
https://github.com/EverythingMe/gaia/commit/15d34cc2ed1960396de46b0cb609f1b1f57ebbd6

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8435750 [details] [review]
PR

I feel like we are still missing something here, but R+ for now. I will comment in the other bug.

Comment 3

[Amir Nissim (:amirn)]

landed: https://github.com/mozilla-b2g/gaia/commit/22b545eafa077ff871fc5a31c1315609b7724601

Comment 4

[Johan Lorenzo [:jlorenzo]]

As the bug is landed, I guess the issue is fixed. Please reopen if it's not.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8435750 [details] [review]
PR

This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8435750 [details] [review]
PR

Turns out this made 2.0, sorry.