1021734 - Remove complicated logic from Marionette's setup.py dealing with transport

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Jonathan Griffin (:jgriffin)]

We have weird logic in Marionette's setup.py to handle installing marionette-transport from local sources if available.  This is currently breaking Marionette doc generation.

We should change the way we handle installation of marionette-client and marionette-transport to be similar to the mozbase case...in mozharness, we'll do a two-pass install, one without deps and one with, and setup.py will not contain any extra logic.

We may want to provide an in-tree mozbase-style setup_development.py so that it's easy to install both local packages from one command, although changes to transport.py are uncommon so this might not be that important.

Comment 1

[Jonathan Griffin (:jgriffin)]

It looks like mozharness is already doing the right thing; here's a try push to see if we can just simply add marionette-transport as a simple dependency with no other changes:

https://tbpl.mozilla.org/?tree=Try&rev=6b671e783834

Comment 2

[Jonathan Griffin (:jgriffin)]

Attachment: Remove special handling for marionette-transport,

No mozharness changes needed.  I think we don't really need a setup_development.py; that would only be useful for people working directly on marionette-transport and I think such people can figure out how to do a local install.

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8437927 [details] [diff] [review]
Remove special handling for marionette-transport,

Review of attachment 8437927 [details] [diff] [review]:
-----------------------------------------------------------------

Yay!

Comment 4

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc8e76b5073c

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dc8e76b5073c

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Moving bugs for Marionette client due to component changes.