1021811 - Edge Swipe Gesture - User Settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Rob MacDonald [:robmac]]

Attachment: Sheets Setting View (updated copy)

Although the setting to turn edge gestures on and off has been implemented in developer settings, it is missing from user settings as per the spec. (See https://bug991849.bugzilla.mozilla.org/attachment.cgi?id=8402460)

I've also attached an updated version of the settings view to this bug for reference. Also, since this settings category no longer exists, the setting should be located at the bottom of the "Personalization" subhead in Settings.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/20208

Arthur please review the simple new panel patch.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8436632 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20208

Thanks for helping on this. r=me with the comments addressed.

Comment 3

[Fang Shih [:fang]]

Attachment: Settings_Edge Swipe Gesture_icon.zip

Hi Alive, 

Attached the icons! Thank you for waiting! : )

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

PR updated.

We are missing @2.25x images but I think we are ok to land for now.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/2237d4840a18175001b382a27c526e11b654c139