Closed
Bug 1021823
Opened 10 years ago
Closed 10 years ago
[b2gpopulate] Support Android versions <= 17 when mapping volume names to mount points
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: davehunt, Assigned: davehunt)
Details
Attachments
(1 file)
|
1.05 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
It turns out the output from |vdc volume list| changed in versions of Android greater than 17, where an additional column was introduced. We should make sure we support either format.
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8435922 [details] [diff] [review] Support Android versions <= 17 when mapping volume names to mount points. v1.0 This looks good to me. I wonder if it wouldn't be clearer to iterate through the list of volume lines returned by the command and split out the individual elements, though this seems clear enough.
Attachment #8435922 -
Flags: review?(wlachance) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Landed in: https://github.com/mozilla/b2gpopulate/commit/9907ab26455f385d06fbba0726e882d4658ce8ed I agree that it would be good to make the code a little more expressive, so let's take care of that in bug 1020985.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•