1021844 - [Messages] Can't load the application in Firefox

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

This was broken by Bug 1007591.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: github PR

Here is a quick fix so that we can continue to work :)

Comment 2

[Steve Chung [:steveck]]

Comment on attachment 8435940 [details] [review]
github PR

r=me, thanks!

Comment 3

[Julien Wajsberg [:julienw]]

master: 8d865839d932bfbd5e157f376f74d8cb12bfdd51

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8435940 [details] [review]
github PR

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1007591
[User impact] if declined: we can't load the SMS app in Firefox which makes it difficult to debug stuff
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

The code path should never happen on a device because mozSetMessageHandler is always present on the device.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/b2e21b3252489d8c37477b17866d528ccf613fee

Comment 6

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0

Flame v2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0