hg review-repo diffs are broken

RESOLVED FIXED

Status

MozReview
General
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mcote, Assigned: gmiroshnykov)

Tracking

Production

Details

(Reporter)

Description

3 years ago
When we first tested the Review Board hook in the hg review repo, it successfully filed review requests, but the resulting diffs were partially broken.  See https://reviewboard-dev.allizom.org/r/23/diff/ for an example.

There are two theories: that there are problems with hg diffs (which the rbt command-line tool has worked around), and that there's a bug in Review Board itself (possibly https://code.google.com/p/reviewboard/issues/detail?id=3312).
(Reporter)

Updated

3 years ago
Blocks: 1021929
(Reporter)

Updated

3 years ago
Assignee: nobody → george.miroshnykov
(Assignee)

Comment 1

3 years ago
May be relevant:
https://code.google.com/p/reviewboard/issues/detail?id=895
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
I was able to reproduce this (or similar) bug using latest ReviewBoard + RBTools:
https://gist.github.com/laggyluke/cf1c8885948621a4afa2
If even "rbt post" fails, I'm not sure we can work around it in the hook.
Mark, any advice?
Flags: needinfo?(mcote)
(Reporter)

Comment 3

3 years ago
Guh that's frightening.  Maybe smacleod has some ideas.  Unless you have something misconfigured, seems like we really need this fixed upstream.
Flags: needinfo?(mcote) → needinfo?(smacleod)
(Reporter)

Comment 4

3 years ago
I think this is worth bringing up on the Review Board mailing list too.
(Assignee)

Comment 5

3 years ago
Some discussion is happening here:
https://groups.google.com/forum/#!topic/reviewboard/zYCShV-nK7s
(Assignee)

Comment 6

3 years ago
This bug turned out to be caused by Mercurial client misconfiguration (diffs were generated with --git flag) and incorrect parent diff generation.

The fix is in master:
https://github.com/laggyluke/reviewboard-mercurial-hook/commit/aedb4171666de5656e9994f1b23724549b45fc9a
(Reporter)

Comment 7

3 years ago
Seems good on reviewboard-dev.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Updated

3 years ago
Flags: needinfo?(smacleod)
Product: bugzilla.mozilla.org → Developer Services
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.