Closed Bug 1021950 Opened 6 years ago Closed 6 years ago

Delete unwrapBkey from FxA user data after we fetch and calculate keys


(Firefox :: Firefox Accounts, defect)

Not set



Firefox 33


(Reporter: ckarlof, Assigned: warner)



(1 file, 1 obsolete file)

I believe this amounts to adding "delete data.unwrapBKey" here:

and adding some tests to make sure it gets deleted after a successful key fetch.
This should be everything.
Attachment #8437097 - Flags: review?(ckarlof)
Ah, this format of patch should be slightly easier to mark checkin-needed.
Attachment #8437097 - Attachment is obsolete: true
Attachment #8437097 - Flags: review?(ckarlof)
Attachment #8437111 - Flags: review?(ckarlof)
Attachment #8437111 - Flags: review?(ckarlof) → review+
There are two unrelated tests which fail when I run the full suite, but those same tests fail when I run an unmodified git checkout (1f1507a8dac30b1bbf934a801d48a684cf375ae0). So I think this is ready for checkin.
Whiteboard: checkin-needed
Please provide a Try link when requesting checkin. If you need some recommendations on what to run, you can take a look at the below:
Whiteboard: checkin-needed
Thanks Nick!

Ryan: is that sufficient? (sorry, I'm new at using checkin-needed).
Whiteboard: checkin-needed
Flags: in-testsuite+
Whiteboard: checkin-needed → [fixed-in-fx-team]
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla33
Duplicate of this bug: 1026299
Product: Core → Firefox
Target Milestone: mozilla33 → Firefox 33
You need to log in before you can comment on or make changes to this bug.