Closed Bug 1021992 Opened 5 years ago Closed 5 years ago

nsVideoFrame.h has bogus decl for "NS_NewVideoFrame" (which is never defined)

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

nsVideoFrame.h has a declaration for NS_NewVideoFrame, which is never used or defined:
http://mxr.mozilla.org/mozilla-central/search?string=%20NS_NewVideoFrame

The "real" version of this function is NS_NewHTMLVideoFrame
http://mxr.mozilla.org/mozilla-central/ident?i=NS_NewHTMLVideoFrame

Presumably we should be forward-declaring *that* in nsVideoFrame.h, and drop the NS_NewVideoFrame decl.
Or really, we just want to drop the decl from nsVideoFrame, since the forward-decl in nsCSSFrameConstructor.cpp (with all the other NS_New* decls there) is all we need.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8436125 - Flags: review?(cpearce)
Attachment #8436125 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/d01c93428c32
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.