Closed Bug 1022004 Opened 10 years ago Closed 10 years ago

Support loading memory reports that already have heap-unclassified defined

Categories

(Toolkit :: about:memory, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file)

AWSY now supports exporting memory reports, but it already has |heap-unclassified| defined. about:memory should just use that value if it's present.
This patch just bypasses the |heap-unclassified| calculation if the node is already present.
Attachment #8436153 - Flags: review?(n.nethercote)
Comment on attachment 8436153 [details] [diff] [review]
Support loading memory reports that already have heap-unclassified defined

Review of attachment 8436153 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/aboutmemory/content/aboutMemory.js
@@ +1233,5 @@
>    if (aHeapAllocatedNode === undefined)
>      return false;
>  
> +  if (aT.findKid("heap-unclassified")) {
> +    // heap-unclassified was already calculated, there's nothing left to do.

Maybe add "This can happen when memory reports are exported from areweslimyet.com."
Attachment #8436153 - Flags: review?(n.nethercote) → review+
Doing a T-push on try is good. For patches affecting memory reporting and/or about:memory, usually running just Mochitest-O is enough, because that's the only test suite that exercises them. Next time! :)
https://hg.mozilla.org/mozilla-central/rev/8e06ca7ce4ce
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
It just occurred to me that I should have got you to modify one of the files loaded by the tests to include a heap-unclassified value...
Blocks: 1022965
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: