1022023 - [B2G][Calendar][Week View]All day events do not display correctly in week view

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Ross Kuhlman ([e-mail])]

Attachment: CalendarWeekViewComparison.jpg

All day events are displayed at the top of the screen in day and week view. When in week view, all day events do not display correctly. The orange rectangle is not tall enough, and does not fill the available space

Repro Steps:
1) Update a Flame to BuildID: 20140606040202
2) Launch Calendar app.
3) Tap '+' button to create a new event.
4) Tap 'All Day' toggle and save the event.
5) Tap on week tab at bottom of screen.
6) Observe all day event in week view.

Actual:
Rectangle for all day event does not properly fill alotted space.

Expected:
Rectangle properly fills alotted space

Master M/C Environmental Variables:
Device: Flame Master M/C MOZ
BuildID: 20140606040202
Gaia: 857129928b6e56a809cee9d5445effb8fa9f1c2c
Gecko: c8288d0c7a15
Version: 32.0a1
Firmware Version: v10G-2

Notes:

Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/13107/
See attached: screenshot

Comment 1

[Jason Smith [:jsmith]]

Please needinfo jmitchell on all triage? bugs.

Comment 2

[Jason Smith [:jsmith]]

QA Wanted to check 1.4.

Comment 3

[Ross Kuhlman ([e-mail])]

On Buri 2.0 and Open-C 2.0, both the originally reported issue and the different event sizes for all day events (title vs no title) occur
  
Environmental Variables:
Device: Buri 2.0
Build ID: 20140616000203
Gaia: a6988c15b361938bea5976c846c147ecdc1121c0
Gecko: 52a276202888
Version: 32.0a2 (2.0) 
Firmware Version: v1.2device.cfg

Device: Open-C v2.0 MOZ
BuildID: 20140616000203
Gaia: a6988c15b361938bea5976c846c147ecdc1121c0
Gecko: 52a276202888
Version: 32.0a2
Firmware Version: P821A10v1.0.0B06_LOG_DL


On 1.4 Flame only the issue with the all day events not taking up the entire cell occurs (no difference between title vs no title)
Environmental Variables:
Device: Flame 1.4
Build ID: 20140616000202
Gaia: 164644d91290708a71436dfdf4301e33b92e2c77
Gecko: 2949e8bef869
Version: 30.0 (1.4) 
Firmware Version: v121-2

Comment 4

[Jason Smith [:jsmith]]

When a QA Wanted request is complete, please needinfo your lead for review.

Comment 5

[Joshua Mitchell (Inactive)]

QA-Wanted to do the rest of the branch/device checks

Comment 6

[Harvey]

This issue DOES reproduce on Buri 2.1

Environmental Variables: 
Device: Buri 2.1 - Master 
Build ID: 20140624090716 
Gaia: 2944695a89c3281d49dbe5ff9c0cd26c8318e2ba 
Gecko: 215b93e07e1d 
Version: 33.0a1 (2.1 - Master) 
Firmware Version: v1.2device.cfg


On 1.4 Buri and the Flame Base Image v122 only the issue with the all day events not taking up the entire cell occurs (no difference between title vs no title)

Environmental Variables: 
Device: Buri 1.4 
Build ID: 20140610034016 
Gaia: c39db439202b29897bee9896bc789e6782809f3a 
Gecko: edd648be2b07 
Version: 30.0 (1.4) 
Firmware Version: v1.2device.cfg

Environmental Variables: 
Device: Flame 1.3 
Version: 28.0 (1.3) 
Firmware Version: v122

Comment 7

[Joshua Mitchell (Inactive)]

Not nomming as a blocker. This bug is an appearance issue only and does not affect functionality. The user must specifically not enter a title to see the smaller box and even then the user is still able to click on and interact with the event box.

Comment 8

[Miller Medeiros [:millermedeiros]]

the all day event doesn't fill the whole area because we want user to know that he doesn't need to scroll. it would look weird if we had a single event covering the whole area and if we had 2+ events we changed the height. that way we always keep it consistent.

I'll add a minimum height to the element so it should always have the same height (with or without a title).

Comment 9

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20998

added minimum height to keep it consistent with events that have a title

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8446216 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20998

No issues here :)

Comment 11

[Miller Medeiros [:millermedeiros]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/4a3ad21670abbfd3bb9ed1f70a8c84d72ce6dd9b

Comment 12

[Edward Chen[:edchen]]

[Environment]
Gaia      43226cf5c3ad19728a88b3786595670b6d60e5c6
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/d0275ba5f438
BuildID   20140701160202
Version   32.0a2
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[Result]
Pass

Comment 13

[Himanshu]

[Tracking Requested - why for this release]:

Comment 14

[Sylvestre Ledru [:Sylvestre]]

31 has been released. Too late for that.

Comment 15

[Lancy(Leave from Mozilla)]

Attachment: Verify_1022022.png

According to Comment 8, height of colored rectangle changes if title is present(See the attachment:Verify_1022022.png ), but the all day event in week view does not fill all the available space.

Ross, Could you help me to confirm the issue has been fixed?