1022050 - Disable the SEH block used in TestPoisonArea.cpp on clang-cl until it grows SEH support

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Comment 1

[(no longer active)]

Attachment: Disable the SEH block used in TestPoisonArea.cpp on clang-cl until it grows SEH support

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8436195 [details] [diff] [review]
Disable the SEH block used in TestPoisonArea.cpp on clang-cl until it grows SEH support

This should be
#if defined(_MSC_VER) && !(defined(_HAS_EXCEPTIONS) && _HAS_EXCEPTIONS == 0)

That matches what standard library does and will automatically enable itself once clang gets support for exceptions

Comment 3

[Mike Hommey [:glandium]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #2)
> Comment on attachment 8436195 [details] [diff] [review]
> Disable the SEH block used in TestPoisonArea.cpp on clang-cl until it grows
> SEH support
> 
> This should be
> #if defined(_MSC_VER) && !(defined(_HAS_EXCEPTIONS) && _HAS_EXCEPTIONS == 0)
> 
> That matches what standard library does and will automatically enable itself
> once clang gets support for exceptions

Except we explicitly set _HAS_EXCEPTIONS=0, so it would never enable itself, and would in fact also be disabled in msvc.

Comment 4

[(no longer active)]

Comment on attachment 8436195 [details] [diff] [review]
Disable the SEH block used in TestPoisonArea.cpp on clang-cl until it grows SEH support

glandium is right.  Jeff, my plan is to periodically look at the __clang__ occurrences in the tree and take care of them.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8436195 [details] [diff] [review]
Disable the SEH block used in TestPoisonArea.cpp on clang-cl until it grows SEH support

Review of attachment 8436195 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/tests/TestPoisonArea.cpp
@@ +406,5 @@
>    } __except (EXCEPTION_EXECUTE_HANDLER) {
>      ret = true;
>    }
>  #else
>    printf("INFO | exec test not supported on MinGW build\n");

Can you modify this, too?

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a0b0886c3ed1

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a0b0886c3ed1