Closed Bug 1022133 Opened 6 years ago Closed 6 years ago

Disable HTTP cache v2 for Thunderbird

Categories

(MailNews Core :: Networking, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 32.0

People

(Reporter: mayhemer, Assigned: mayhemer)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Blocks: mail-cache2
Attached patch v1 (obsolete) — Splinter Review
Attachment #8436305 - Flags: review?(Pidgeot18)
Comment on attachment 8436305 [details] [diff] [review]
v1

Review of attachment 8436305 [details] [diff] [review]:
-----------------------------------------------------------------

Fortunately for you, I couldn't go back to sleep after waking up this morning, so I actually have a small window of time to actually review this.

This does make both the probably-cache-related failing tests pass, which I assume is a decent enough proxy to gauge which cache is being used.

::: mail/app/profile/all-thunderbird.js
@@ +868,5 @@
>  // If set to true, when saving a message to a file, use underscore
>  // instead of space in the file name.
>  pref("mail.save_msg_filename_underscores_for_space", false);
> +
> +// Disable cache v2 since migration has not been done

Can you note here the bug where the migration in c-c will be done? I suppose that's bug 1021843 at this point...
Attachment #8436305 - Flags: review?(Pidgeot18) → review+
(In reply to Joshua Cranmer [:jcranmer] (away June 7-12) from comment #2)
> Comment on attachment 8436305 [details] [diff] [review]
> v1
> 
> Review of attachment 8436305 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Fortunately for you, I couldn't go back to sleep after waking up this
> morning, so I actually have a small window of time to actually review this.

I had today something very similar!  What a coincidence..

I'll update and land.  Thanks!
Attached patch v1.1 [to land]Splinter Review
Here is a try push https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=865b93680d14

Will land when green enough.
Attachment #8436305 - Attachment is obsolete: true
Attachment #8436311 - Flags: review+
Seems OK to me, at least nothing visibly cache related.

When I get approval for c-c landing, I will push it.
Can someone land this please for me?  Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/f54c834090c2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 32.0
You need to log in before you can comment on or make changes to this bug.